-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove conda default channel #332
Conversation
Warning Rate limit exceeded@jan-janssen has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 44 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe updates across multiple GitHub Actions workflow files involve a significant restructuring of Conda environment setup. The changes include replacing the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (13)
- .github/workflows/coverage.yml (1 hunks)
- .github/workflows/deploy.yml (1 hunks)
- .github/workflows/minimal.yml (1 hunks)
- .github/workflows/notebooks.yml (1 hunks)
- .github/workflows/pypicheck.yml (1 hunks)
- .github/workflows/unittests.yml (1 hunks)
- .github/workflows/unittests_abinit.yml (1 hunks)
- .github/workflows/unittests_gpaw.yml (1 hunks)
- .github/workflows/unittests_mace.yml (1 hunks)
- .github/workflows/unittests_matgl.yml (1 hunks)
- .github/workflows/unittests_old.yml (1 hunks)
- .github/workflows/unittests_qe.yml (1 hunks)
- .github/workflows/unittests_siesta.yml (1 hunks)
Additional comments not posted (42)
.github/workflows/minimal.yml (3)
13-14
: LGTM!The step correctly creates a
.condarc
file with theconda-forge
channel.The code changes are approved.
19-20
: LGTM!The step correctly sets up Mambaforge with the latest version and uses the
.condarc
file.The code changes are approved.
Line range hint
25-31
: LGTM!The step correctly installs dependencies and runs tests.
The code changes are approved.
.github/workflows/unittests_old.yml (3)
13-14
: LGTM!The step correctly creates a
.condarc
file with theconda-forge
channel.The code changes are approved.
19-20
: LGTM!The step correctly sets up Mambaforge with the latest version and uses the
.condarc
file.The code changes are approved.
Line range hint
25-31
: LGTM!The step correctly installs dependencies and runs tests.
The code changes are approved.
.github/workflows/pypicheck.yml (3)
15-16
: LGTM!The step correctly creates a
.condarc
file with theconda-forge
channel.The code changes are approved.
20-22
: LGTM!The step correctly sets up Mambaforge with the latest version and uses the
.condarc
file.The code changes are approved.
Line range hint
27-31
: LGTM!The step correctly installs dependencies and runs pip checks.
The code changes are approved.
.github/workflows/unittests_siesta.yml (3)
17-17
: LGTM!Creating a
.condarc
file to specify theconda-forge
channel centralizes the channel configuration and improves maintainability.The code changes are approved.
22-22
: LGTM!Using
miniforge-version: latest
ensures that the latest version of Miniforge is used, providing up-to-date features and bug fixes.The code changes are approved.
23-23
: LGTM!Referencing the
.condarc
file in thesetup-miniconda
action ensures consistent application of the channel configuration.The code changes are approved.
.github/workflows/notebooks.yml (3)
19-19
: LGTM!Creating a
.condarc
file to specify theconda-forge
channel centralizes the channel configuration and improves maintainability.The code changes are approved.
24-24
: LGTM!Using
miniforge-version: latest
ensures that the latest version of Miniforge is used, providing up-to-date features and bug fixes.The code changes are approved.
25-25
: LGTM!Referencing the
.condarc
file in thesetup-miniconda
action ensures consistent application of the channel configuration.The code changes are approved.
.github/workflows/unittests_gpaw.yml (3)
17-17
: LGTM!Creating a
.condarc
file to specify theconda-forge
channel centralizes the channel configuration and improves maintainability.The code changes are approved.
22-22
: LGTM!Using
miniforge-version: latest
ensures that the latest version of Miniforge is used, providing up-to-date features and bug fixes.The code changes are approved.
23-23
: LGTM!Referencing the
.condarc
file in thesetup-miniconda
action ensures consistent application of the channel configuration.The code changes are approved.
.github/workflows/unittests_mace.yml (3)
17-17
: LGTM!Creating a
.condarc
file to specify theconda-forge
channel centralizes channel configuration and simplifies the setup process.The code changes are approved.
22-22
: LGTM!Updating the
miniforge-version
parameter tolatest
ensures that the most recent features and fixes are included.The code changes are approved.
23-23
: LGTM!Adding the
condarc-file
parameter to specify the path to the.condarc
file ensures that the defined channels are utilized during the environment setup.The code changes are approved.
.github/workflows/unittests_abinit.yml (3)
17-17
: LGTM!Creating a
.condarc
file to specify theconda-forge
channel centralizes channel configuration and simplifies the setup process.The code changes are approved.
22-22
: LGTM!Updating the
miniforge-version
parameter tolatest
ensures that the most recent features and fixes are included.The code changes are approved.
23-23
: LGTM!Adding the
condarc-file
parameter to specify the path to the.condarc
file ensures that the defined channels are utilized during the environment setup.The code changes are approved.
.github/workflows/unittests_matgl.yml (3)
17-17
: LGTM!Creating a
.condarc
file to specify theconda-forge
channel centralizes channel configuration and simplifies the setup process.The code changes are approved.
22-22
: LGTM!Updating the
miniforge-version
parameter tolatest
ensures that the most recent features and fixes are included.The code changes are approved.
23-23
: LGTM!Adding the
condarc-file
parameter to specify the path to the.condarc
file ensures that the defined channels are utilized during the environment setup.The code changes are approved.
.github/workflows/unittests_qe.yml (3)
17-17
: LGTM!Creating the
.condarc
file to centralize channel configuration is a good practice for maintainability.The code changes are approved.
22-22
: LGTM!Setting
miniforge-version
tolatest
ensures that the latest updates and improvements are used.The code changes are approved.
23-23
: LGTM!Using the
condarc-file
parameter to specify the.condarc
file improves the management of Conda configurations.The code changes are approved.
.github/workflows/deploy.yml (6)
22-23
: LGTM!Adding a step to create the
.condarc
file centralizes channel configuration, which is a good practice for maintainability.The code changes are approved.
26-26
: LGTM!Updating to Python 3.12 ensures compatibility with the latest features and improvements.
The code changes are approved.
27-27
: LGTM!Setting
miniforge-version
tolatest
ensures that the latest updates and improvements are used.The code changes are approved.
28-28
: LGTM!Using the
condarc-file
parameter to specify the.condarc
file improves the management of Conda configurations.The code changes are approved.
23-23
: LGTM!The removal of the
mamba-version
parameter simplifies the configuration.The code changes are approved.
23-23
: LGTM!The removal of the
channels
,miniforge-variant
,channel-priority
, andauto-update-conda
parameters simplifies the configuration and centralizes the channel management in the.condarc
file.The code changes are approved.
.github/workflows/coverage.yml (3)
20-20
: LGTM!Creating the
.condarc
file to centralize channel configuration is a good practice for maintainability.The code changes are approved.
25-25
: LGTM!Setting
miniforge-version
tolatest
ensures that the latest updates and improvements are used.The code changes are approved.
26-26
: LGTM!Using the
condarc-file
parameter to specify the.condarc
file improves the management of Conda configurations.The code changes are approved.
.github/workflows/unittests.yml (3)
40-40
: LGTM!The creation of the
.condarc
file with theconda-forge
channel is correctly implemented and improves maintainability.The code changes are approved.
45-45
: LGTM!Replacing
miniforge-variant
withminiforge-version: latest
simplifies the version specification and ensures the latest version is always used.The code changes are approved.
46-46
: LGTM!Replacing the
channels
parameter withcondarc-file: .condarc
aligns with the new approach of managing channels via a.condarc
file, enhancing clarity and maintainability.The code changes are approved.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
.condarc
file.