Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend range in Hessian Test #146

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Extend range in Hessian Test #146

wants to merge 1 commit into from

Conversation

jan-janssen
Copy link
Member

No description provided.

@liamhuber
Copy link
Member

liamhuber commented Dec 18, 2023

Edit: we should discuss this PR live post meeting if you have time. It has mission-critical flaws I'm concerned about.

@jan-janssen
Copy link
Member Author

@liamhuber I guess we missed this point during the meeting. I agree that the test could be more clever. If you find the time maybe you can open a pull request and then we can continue the discussion there.

@liamhuber
Copy link
Member

@liamhuber I guess we missed this point during the meeting. I agree that the test could be more clever. If you find the time maybe you can open a pull request and then we can continue the discussion there.

I will not be able to make such a contribution before the Christmas holiday and in January will be laser-focused on storage for pyiron_workflow. All my concerns are outlined in #149, so we won't lose track of it in case it takes a while for me to get to it, and there's plenty enough there for someone not-me to be able to make the changes.

@jan-janssen jan-janssen marked this pull request as draft February 14, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants