Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dark mode #113

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Support dark mode #113

wants to merge 5 commits into from

Conversation

ischaojie
Copy link
Contributor

@ischaojie ischaojie commented Dec 21, 2023

fixes: #39

2023-12-28 15 26 59

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.02%. Comparing base (16abe6a) to head (10ac780).
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   95.68%   97.02%   +1.33%     
==========================================
  Files          14       15       +1     
  Lines         950     1176     +226     
==========================================
+ Hits          909     1141     +232     
+ Misses         41       35       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sydney-runkle
Copy link
Member

Hi @ischaojie,

Is this ready for review? Would love to get this feature out with 0.6.0 :).

@shroominic
Copy link

shroominic commented Jun 8, 2024

excited waiting... how can we get this shipped? Anything we can help?

@hasansezertasan
Copy link
Contributor

Great job @ischaojie, when will we be having this feature?

@virhilo
Copy link

virhilo commented Sep 25, 2024

Awesome job @ischaojie! Was this PR abandoned though?

@ischaojie
Copy link
Contributor Author

Awesome job @ischaojie! Was this PR abandoned though?

Sorry, I haven't been paying attention for a while, It looks like there are some conflicts that need to be resolved. I will make time.

@ischaojie
Copy link
Contributor Author

ischaojie commented Sep 27, 2024

It's ready for review :) @sydney-runkle

@ischaojie ischaojie marked this pull request as ready for review September 27, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark Mode
5 participants