_parse_semantic_location_history: handle missing placeId in otherCandidateLocations #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idateLocations should resolve purarue#57
|
thanks again 👍 |
|
Ah slipped a FIXME by accident, you beat me by a few seconds 😅 will remove in some subsequent PR |
|
yeah, no problem |
purarue
added a commit
that referenced
this pull request
Sep 26, 2024
* support both "Location History" and "Location History (Timeline)" directories by @karlicoss in #70 * _parse_semantic_location_history: handle missing placeId in otherCandidateLocations by @karlicoss in #71 * path_dispatch: speedup dispatch map about 80% by @karlicoss in #72 * fix for youtube comments csv + old Chrome/MyActivity.json by @karlicoss in #73 * Add missing type annotations for bs4 and pytz in testing environment by @mighabana in #75 * get_paths_for_function: fix failure on Windows by @karlicoss in #78 * Add additional fields to existing models by @mighabana in #76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all (few thousand!) errors in my case, now this parses exactly across all history
should resolve #57