optimizations for GoogleEventSet, speeding up merging 20+% #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All objects from takeout pass through this merging HPI so worth speeding it up
add
add_if_not_present
method to avoid computing key twice (which is quite expensive!)This is intended to be used as a replacement for (e.g. in HPI)
With this method, we could rewrite as:
This could be introduced to hpi with backwards compatibility.
use type directly as key, types are hashable (very tiny speedup, but it also feels more natural anyway)