Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PPA in deb822 format #1169

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

fredericgiquel
Copy link

Summary

Since Ubuntu 23.10, add-apt-repository no longer creates a .list file but a .sources file (in deb822 format).

Additional Context

Related Issues (if any)

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@CLAassistant
Copy link

CLAassistant commented Mar 12, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related: #1167.

manifests/ppa.pp Outdated Show resolved Hide resolved
@grant-veepshosting
Copy link

grant-veepshosting commented Oct 16, 2024

There seems to be an extra leading $ character on L59 in manifests/ppa.pp main branch.

manifests/ppa.pp Outdated Show resolved Hide resolved
@grant-veepshosting
Copy link

@smortex is there a chance you could look at merging this PR (and the related one)?

@kenyon kenyon mentioned this pull request Nov 21, 2024
3 tasks
fredericgiquel and others added 3 commits November 25, 2024 20:19
Co-authored-by: Kenyon Ralph <kenyon@kenyonralph.com>
Co-authored-by: Kenyon Ralph <kenyon@kenyonralph.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants