This repository has been archived by the owner on Feb 18, 2022. It is now read-only.
Fix support for no verify #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On RHEL 7, which has Stunnel version 4.56, we found that a different configuration was required. Instead of specifying verify = default, it is in fact necessary to simply not specify verify at all. Without this patch applied, an error message is seen: "verify = default": Bad verify level On RHEL 6, Stunnel version 4.29 is available and it behaves differently, but it also allows verify to simply be not specified. Therefore, this patch modifies templates/stunnel.conf.erb to simply not add the verify line if verify level default is specified.
Before this, the Travis build was failing with:
Using rake 12.0.0
Gem::InstallError: public_suffix requires Ruby version >= 2.0.
An error occurred while installing public_suffix (2.0.5), and Bundler
cannot
Considering that Ruby 1.9.3 is very very old now, it seems to make sense
to simply remove it from .travis.yml, which is what this patch does.
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On RHEL 7, which has Stunnel version 4.56, we found that a different
configuration was required.
Instead of specifying verify = default, it is in fact necessary to
simply not specify verify at all.
Without this patch applied, an error message is seen:
"verify = default": Bad verify level
On RHEL 6, Stunnel version 4.29 is available and it behaves differently,
but it also allows verify to simply be not specified.
Therefore, this patch modifies templates/stunnel.conf.erb to simply not
add the verify line if verify level default is specified.