Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate https://github.com/atom/flight-manual.atom.io/pull/699 #85

Closed
wants to merge 1 commit into from

Conversation

icecream17
Copy link
Contributor

Also going to mention atom/flight-manual.atom.io#631

@confused-Techie
Copy link
Member

While this would be a smart thing to add for our current documentation. My concern is that looks to be a file within the archived Atom Docs. Are we modifying their work in other areas? I was under the assumption that the original Atom docs are essentially untouched, which in my opinion means to leave any mistakes, just as long as we correct them ourselves.

@pulsar-edit/documentation Is this a correct assumption?

@icecream17
Copy link
Contributor Author

I didn't remember that when I made this pull, oops...

Yeah I vaguely remember something like that being said?

@Daeraxa
Copy link
Member

Daeraxa commented Nov 7, 2022

If this change isn't merged on the atom repo then we should leave it as it is but we absolutely should include it into the refactored docs.

It just so happens the PR for ch2 is still pending review (#59) so feel free to add the change as a suggestion to that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants