Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #1830/09212672 backport][2.20] Fix an issue with auth header validation #1833

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[PR #1830/09212672 backport][2.20] Fix an issue with auth header validation #1833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES/1812.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fixed a bug where the authentication scheme in the authorization header
was not being parsed correctly.
4 changes: 2 additions & 2 deletions pulp_container/app/downloaders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ async def _run(self, handle_401=True, extra_data=None):
# Need to retry request
if handle_401 and e.status == 401 and response_auth_header is not None:
# check if bearer or basic
if "Bearer" in response_auth_header:
if "bearer" in response_auth_header.lower():
# Token has not been updated during request
if (
self.registry_auth["bearer"] is None
Expand All @@ -93,7 +93,7 @@ async def _run(self, handle_401=True, extra_data=None):
self.registry_auth["bearer"] = None
await self.update_token(response_auth_header, this_token, repo_name)
return await self._run(handle_401=False, extra_data=extra_data)
elif "Basic" in response_auth_header:
elif "basic" in response_auth_header.lower():
if self.remote.username:
basic = aiohttp.BasicAuth(self.remote.username, self.remote.password)
self.registry_auth["basic"] = basic.encode()
Expand Down