-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate command reference in docs #797
Draft
mdellweg
wants to merge
1
commit into
pulp:main
Choose a base branch
from
mdellweg:auto_docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
mkdocs | ||
mkdocs-click |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
::: mkdocs-click | ||
:module: pulp_cli | ||
:command: main | ||
:prog_name: pulp | ||
:depth: 0 | ||
:list_subcommands: false | ||
:style: plain |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,33 +1,22 @@ | ||
import typing as t | ||
from types import ModuleType | ||
from typing import Any, Dict, Optional | ||
|
||
import click | ||
import pkg_resources | ||
|
||
__version__ = "0.22.0.dev" | ||
_main: Optional[click.Group] = None | ||
|
||
|
||
def load_plugins() -> click.Group: | ||
global _main | ||
############################################################################## | ||
# Load plugins | ||
# https://packaging.python.org/guides/creating-and-discovering-plugins/#using-package-metadata | ||
discovered_plugins: t.Dict[str, ModuleType] = { | ||
entry_point.name: entry_point.load() | ||
for entry_point in pkg_resources.iter_entry_points("pulp_cli.plugins") | ||
} | ||
|
||
############################################################################## | ||
# Load plugins | ||
# https://packaging.python.org/guides/creating-and-discovering-plugins/#using-package-metadata | ||
discovered_plugins: Dict[str, ModuleType] = { | ||
entry_point.name: entry_point.load() | ||
for entry_point in pkg_resources.iter_entry_points("pulp_cli.plugins") | ||
} | ||
_main = discovered_plugins["common"].main | ||
assert isinstance(_main, click.Group) | ||
for plugin in discovered_plugins.values(): | ||
if hasattr(plugin, "mount"): | ||
plugin.mount(_main, discovered_plugins=discovered_plugins) | ||
return _main | ||
main: click.Group = t.cast(click.Group, discovered_plugins["common"].main) | ||
|
||
|
||
def main() -> Any: | ||
if _main is None: | ||
load_plugins() | ||
assert _main is not None | ||
return _main() | ||
for plugin in discovered_plugins.values(): | ||
if hasattr(plugin, "mount"): | ||
plugin.mount(main, discovered_plugins=discovered_plugins) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you need to change the way the main command is loaded for the docs building?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, unfortunately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any downsides to this new approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If i remember correctly, i wanted to have a way to defer plugin loading until one could select the plugins to load in a config file. But that never worked. So probably no.