Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gtfs feed for straeto (iceland) #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kemkim
Copy link
Contributor

@kemkim kemkim commented Jun 25, 2022

Iceland long-distance coaches

Iceland long-distance coaches
@derhuerst derhuerst requested a review from juliuste June 25, 2022 17:19
@juliuste
Copy link
Member

Thanks for the contribution and the effort to drive this project forward! ❤️

Following my comment in #4, I'd still like to go with the one feed per country rule. This implies that we should only add feeds that either already contain all transport of a given country, or at least are designated to do so in the future.

Are there any public transport services in Iceland that are not operated by Straeto, which provides the feed? If not, I'm happy to merge this, otherwise I'm not sure.

@juliuste juliuste changed the title Update feeds.toml add gtfs feed for straeto (iceland) Jul 16, 2022
@juliuste
Copy link
Member

juliuste commented May 1, 2023

Follow-up: I tried to clarify the criteria in our readme

There should only be one feed per country. This feed should also have the scope to (at least eventually) cover the entire country. A counter-example for this would be feeds limited to a specific operator, since such a feed would - by definition - always exclude additional data. Feeds that are not 100% complete but have the scope to cover the whole country eventually are acceptable, though. If some country doesn't have a global feed (yet), you're encouraged to describe the current situation in a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants