Cheatman: Add user cheat selection

[KrahJohlito]

Pull Request checklist

Note: these are not necessarily requirements

• I reformatted the code with clang-format
• I checked to make sure my submission worked
• I am the author of submission or have permission from the original author
• Requires update of the PS2SDK or other dependencies
• Others (please specify below)

Pull Request description

This adds a cheat selection menu at game launch if the cheat mode is selected in cheat settings. It will read your cht file and group the title description to the code below and it is that title that will be displayed in the menu, for this reason its a good idea to have your cht files descriptive and concise. See screenshots below for examples.

Also just some general clean ups to the cheat system.

[iGom]

works like a charm

[AKuHAK]

@KrahJohlito can you add few words about this feature into readme as part of this PR?

[israpps]

A little idea that will save us LOTS of invalid issue reports
What if the cheat engine frontent automatically ticks any cheat named Mastercode

[KrahJohlito]

A little idea that will save us LOTS of invalid issue reports What if the cheat engine frontent automatically ticks any cheat named Mastercode

Because of the way the cheat system works they’re all ticked/on by default, because both modes use the same code but if mode == 1 a menu pops up so you can disable whatever cheats you don’t want. Otherwise it just boots with all in their default state (enabled).

It (currently) does not carry over subsequent boots so you need to disable each time.. I couldn’t decide the best way to go about it.. do we write hashes to the cht file to save them as disabled? Do we write a new file containing just the names of the enabled cheats and then compare that to the cht file to only auto enable the same ones next time the menu opens? I ran out of time to make a decision and this is still an improvement over the old system so just opened the PR. Cheat system could still be improved further in the future though.

[KrahJohlito]

@KrahJohlito can you add few words about this feature into readme as part of this PR?

Sure I’ll try write something later (and I’ll fix the conflict)

[AKuHAK]

A little idea that will save us LOTS of invalid issue reports What if the cheat engine frontent automatically ticks any cheat named Mastercode

Because of the way the cheat system works they’re all ticked/on by default, because both modes use the same code but if mode == 1 a menu pops up so you can disable whatever cheats you don’t want. Otherwise it just boots with all in their default state (enabled).

It (currently) does not carry over subsequent boots so you need to disable each time.. I couldn’t decide the best way to go about it.. do we write hashes to the cht file to save them as disabled? Do we write a new file containing just the names of the enabled cheats and then compare that to the cht file to only auto enable the same ones next time the menu opens? I ran out of time to make a decision and this is still an improvement over the old system so just opened the PR. Cheat system could still be improved further in the future though.

I think that @israpps meant that mastercode section should be mandatory, non-disablable, and maybe even not visible in gui.

[KrahJohlito]

A little idea that will save us LOTS of invalid issue reports What if the cheat engine frontent automatically ticks any cheat named Mastercode

Because of the way the cheat system works they’re all ticked/on by default, because both modes use the same code but if mode == 1 a menu pops up so you can disable whatever cheats you don’t want. Otherwise it just boots with all in their default state (enabled).
It (currently) does not carry over subsequent boots so you need to disable each time.. I couldn’t decide the best way to go about it.. do we write hashes to the cht file to save them as disabled? Do we write a new file containing just the names of the enabled cheats and then compare that to the cht file to only auto enable the same ones next time the menu opens? I ran out of time to make a decision and this is still an improvement over the old system so just opened the PR. Cheat system could still be improved further in the future though.

I think that @israpps meant that mastercode section should be mandatory, non-disablable, and maybe even not visible in gui.

alright I made it so mastercode or master code and their variants can't be disabled .. I think leaving it visible is a good idea so users can see if they have a valid mastercode.. will take care of most variants but we can't account for all master-code master_code etc at some point users just need to have some semblance of understanding about the system they're using.

added a readme entry for cheats.. idk if you want it as a separate commit but there it is, if it's not sufficient someone is free to edit it.