Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOC related fixes #1055

Merged
merged 1 commit into from
Aug 19, 2023
Merged

TOC related fixes #1055

merged 1 commit into from
Aug 19, 2023

Conversation

AKuHAK
Copy link
Member

@AKuHAK AKuHAK commented Aug 14, 2023

CD toc made more user friendly
Fixed non-working DVD-DL toc

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK or other dependencies
  • Others (please specify below)

Pull Request description

@AKuHAK AKuHAK requested a review from rickgaiser August 14, 2023 09:51
@AKuHAK
Copy link
Member Author

AKuHAK commented Aug 14, 2023

@rickgaiser I took your idea about TOC filling but modified it due to SCSI specs be a little different. Some fields still are under question, probably it will be useful to dump TOC from real CD (and DVD) to compare with our data. Also a2, a1, a0 are filled, but CD also has Track 01 with data, and it should also be filled in TOC. And DVD values looks too generic, will be useful to understand what does mean each value.

modules/iopcore/cdvdman/ncmd.c Outdated Show resolved Hide resolved
modules/iopcore/cdvdman/ncmd.c Outdated Show resolved Hide resolved
modules/iopcore/cdvdman/ncmd.c Show resolved Hide resolved
@AKuHAK AKuHAK marked this pull request as draft August 15, 2023 13:11
Fixed non-working DVD-DL toc
@AKuHAK AKuHAK marked this pull request as ready for review August 16, 2023 06:37
@AKuHAK
Copy link
Member Author

AKuHAK commented Aug 17, 2023

@rickgaiser I hope that it is fixed now.

@rickgaiser
Copy link
Member

Thanks, merging.

@rickgaiser rickgaiser merged commit 17efb44 into ps2homebrew:master Aug 19, 2023
26 checks passed
citronalco pushed a commit to citronalco/OPL-Daily-Builds that referenced this pull request Sep 10, 2023
@AKuHAK AKuHAK deleted the kr_test1108 branch March 16, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants