Add metadata example #289
Open
Add metadata example #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swaagie
force-pushed
the
metadata-example
branch
2 times, most recently
from
e5f9a4a
to
4077239
Compare
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
Swaagie
force-pushed
the
metadata-example
branch
from
4077239
to
63e7058
Compare
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
PiotrSikora
requested changes
Nov 26, 2024
| body: | ||
| inline_string: "Welcome, set the `x-custom-metadata` header to change the response!\n" | ||
| http_filters: | ||
| # Set metadata |
There was a problem hiding this comment.
Nit: Set metadata in Lua filter
| local data = headers:get("x-custom-metadata") | ||
|
|
||
| if data then | ||
| request_handle:streamInfo():dynamicMetadata():set("envoy.filters.http.lua", "x-custom-metadata", data) |
There was a problem hiding this comment.
Nitpicking, but it would be slightly more realistic and easier to understand the flow if:
- Lua did something with the input (e.g. convert to uppercase),
- Metadata key would be different from the HTTP header name.
| @@ -22,6 +22,7 @@ | |||
| - [HTTP Response body](./examples/http_body/) | |||
| - [HTTP Configuration](./examples/http_config/) | |||
| - [gRPC Auth (random)](./examples/grpc_auth_random/) | |||
| - [Filter metadata](./examples/filter_metadata/) | |||
There was a problem hiding this comment.
Could you rename this to Envoy filter metadata to make it clear that it's Envoy-specific feature (here and everywhere else throughout this PR)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #288. Happy to adjust this to where it has the most value/clear use cases.