Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ticket 1282 #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

victor-homyakov
Copy link
Contributor

Attempt to fix https://prototype.lighthouseapp.com/projects/8886/tickets/1282-latest-prototypejs-from-github-repo-fails-in-opera

Opera (at least 11.X) has false positive result in feature test 'styleFloat' in DIV.style, but should have its own getStyle_Opera and standard setOpacity/getOpacity.

Another variant:

  if (Prototype.Browser.Opera) {
    // Opera also has 'styleFloat' in DIV.style
    methods.getStyle = getStyle_Opera;
  } else if ('styleFloat' in DIV.style) {
    methods.getStyle = getStyle_IE;
  }
  if (!STANDARD_CSS_OPACITY_SUPPORTED) {
    methods.setOpacity = setOpacity_IE;
    methods.getOpacity = getOpacity_IE;
  }

Attempt to fix https://prototype.lighthouseapp.com/projects/8886/tickets/1282-latest-prototypejs-from-github-repo-fails-in-opera

Opera (at least 11.X) has false positive result in feature test `'styleFloat' in DIV.style`, but should have its own `getStyle_Opera` and standard `setOpacity`/`getOpacity`.

Another variant:

    if (Prototype.Browser.Opera) {
      // Opera also has 'styleFloat' in DIV.style
      methods.getStyle = getStyle_Opera;
    } else if ('styleFloat' in DIV.style) {
      methods.getStyle = getStyle_IE;
    }
    if (!STANDARD_CSS_OPACITY_SUPPORTED) {
      methods.setOpacity = setOpacity_IE;
      methods.getOpacity = getOpacity_IE;
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant