Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hmmm #24

Open
wants to merge 182 commits into
base: patch-4
Choose a base branch
from
Open

Hmmm #24

wants to merge 182 commits into from

Conversation

prono69
Copy link
Owner

@prono69 prono69 commented Jul 13, 2020

No description provided.

@pep8speaks
Copy link

pep8speaks commented Jul 13, 2020

Hello @prono69! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 22:80: E501 line too long (88 > 79 characters)

Line 46:80: E501 line too long (83 > 79 characters)
Line 66:80: E501 line too long (84 > 79 characters)
Line 69:80: E501 line too long (82 > 79 characters)

Line 34:80: E501 line too long (112 > 79 characters)

Line 9:52: W605 invalid escape sequence '\S'
Line 185:80: E501 line too long (83 > 79 characters)
Line 228:80: E501 line too long (89 > 79 characters)

Line 78:42: W605 invalid escape sequence '\S'

Line 40:80: E501 line too long (82 > 79 characters)
Line 43:80: E501 line too long (91 > 79 characters)
Line 50:80: E501 line too long (132 > 79 characters)
Line 58:80: E501 line too long (132 > 79 characters)
Line 60:80: E501 line too long (142 > 79 characters)

Line 19:1: E402 module level import not at top of file

Line 17:1: E402 module level import not at top of file
Line 62:5: E301 expected 1 blank line, found 0

Line 75:80: E501 line too long (85 > 79 characters)

Line 26:60: W605 invalid escape sequence '.'
Line 83:51: E231 missing whitespace after ','

Line 18:80: E501 line too long (90 > 79 characters)
Line 82:80: E501 line too long (90 > 79 characters)
Line 107:27: W291 trailing whitespace
Line 116:80: E501 line too long (86 > 79 characters)
Line 127:1: E302 expected 2 blank lines, found 0

Line 24:80: E501 line too long (82 > 79 characters)

Line 19:1: E265 block comment should start with '# '
Line 23:1: E303 too many blank lines (3)
Line 24:80: E501 line too long (107 > 79 characters)

Line 12:80: E501 line too long (90 > 79 characters)

Line 35:1: W391 blank line at end of file

Line 42:80: E501 line too long (106 > 79 characters)
Line 47:80: E501 line too long (101 > 79 characters)

Line 2:80: E501 line too long (85 > 79 characters)
Line 12:1: E302 expected 2 blank lines, found 1
Line 13:80: E501 line too long (90 > 79 characters)
Line 34:80: E501 line too long (88 > 79 characters)
Line 81:80: E501 line too long (93 > 79 characters)

Line 7:80: E501 line too long (80 > 79 characters)
Line 26:80: E501 line too long (83 > 79 characters)
Line 43:80: E501 line too long (83 > 79 characters)

Line 47:80: E501 line too long (88 > 79 characters)

Line 21:1: W391 blank line at end of file

Line 67:80: E501 line too long (84 > 79 characters)

Line 49:59: E251 unexpected spaces around keyword / parameter equals
Line 49:61: E251 unexpected spaces around keyword / parameter equals
Line 76:80: E501 line too long (106 > 79 characters)

Line 31:13: E722 do not use bare 'except'
Line 31:19: E701 multiple statements on one line (colon)

Line 72:5: E731 do not assign a lambda expression, use a def

Line 16:1: W293 blank line contains whitespace

Line 41:80: E501 line too long (84 > 79 characters)
Line 70:80: E501 line too long (87 > 79 characters)
Line 92:80: E501 line too long (86 > 79 characters)
Line 106:1: W293 blank line contains whitespace
Line 115:80: E501 line too long (88 > 79 characters)

Line 12:80: E501 line too long (88 > 79 characters)

Line 87:80: E501 line too long (87 > 79 characters)
Line 116:58: W605 invalid escape sequence '.'
Line 116:66: W605 invalid escape sequence '.'
Line 116:80: E501 line too long (122 > 79 characters)
Line 116:80: W605 invalid escape sequence '\d'
Line 116:94: W605 invalid escape sequence '\w'
Line 297:80: E501 line too long (98 > 79 characters)
Line 324:80: E501 line too long (87 > 79 characters)
Line 342:80: E501 line too long (94 > 79 characters)
Line 373:80: E501 line too long (81 > 79 characters)
Line 381:80: E501 line too long (85 > 79 characters)
Line 394:80: E501 line too long (85 > 79 characters)
Line 395:80: E501 line too long (97 > 79 characters)

Line 177:80: E501 line too long (80 > 79 characters)
Line 280:80: E501 line too long (82 > 79 characters)
Line 330:1: W391 blank line at end of file

Line 19:80: E501 line too long (86 > 79 characters)

Line 4:80: E501 line too long (81 > 79 characters)
Line 34:80: E501 line too long (94 > 79 characters)
Line 38:80: E501 line too long (94 > 79 characters)
Line 40:80: E501 line too long (94 > 79 characters)

Line 24:80: E501 line too long (92 > 79 characters)

Line 14:80: E501 line too long (90 > 79 characters)

Line 165:80: E501 line too long (87 > 79 characters)
Line 187:80: E501 line too long (92 > 79 characters)
Line 188:80: E501 line too long (92 > 79 characters)

Line 22:80: E501 line too long (91 > 79 characters)
Line 30:80: E501 line too long (80 > 79 characters)
Line 35:80: E501 line too long (85 > 79 characters)
Line 36:80: E501 line too long (85 > 79 characters)

Line 138:80: E501 line too long (90 > 79 characters)

Line 10:80: E501 line too long (82 > 79 characters)
Line 34:44: W605 invalid escape sequence '\s'

Line 111:1: W391 blank line at end of file

Line 47:1: W391 blank line at end of file

Line 10:80: E501 line too long (86 > 79 characters)

Line 32:80: E501 line too long (86 > 79 characters)
Line 56:80: E501 line too long (86 > 79 characters)

Line 25:80: E501 line too long (84 > 79 characters)
Line 28:80: E501 line too long (80 > 79 characters)

Line 40:80: E501 line too long (82 > 79 characters)

Line 25:41: W605 invalid escape sequence '.'
Line 56:80: E501 line too long (100 > 79 characters)

Line 8:1: E302 expected 2 blank lines, found 1

Line 58:14: W291 trailing whitespace

Line 4:5: E306 expected 1 blank line before a nested definition, found 0
Line 7:30: E231 missing whitespace after ','
Line 7:34: E231 missing whitespace after ','
Line 7:38: E231 missing whitespace after ','
Line 7:42: E231 missing whitespace after ','
Line 7:46: E231 missing whitespace after ','
Line 7:50: E231 missing whitespace after ','
Line 18:1: W391 blank line at end of file

Line 210:80: E501 line too long (85 > 79 characters)
Line 226:80: E501 line too long (81 > 79 characters)
Line 237:80: E501 line too long (90 > 79 characters)

Line 77:5: E722 do not use bare 'except'

Line 92:80: E501 line too long (117 > 79 characters)

Line 112:80: E501 line too long (81 > 79 characters)
Line 121:80: E501 line too long (86 > 79 characters)
Line 123:80: E501 line too long (83 > 79 characters)
Line 161:80: E501 line too long (132 > 79 characters)
Line 163:80: E501 line too long (104 > 79 characters)
Line 164:1: W391 blank line at end of file

Line 45:1: E303 too many blank lines (3)

Line 1:27: W291 trailing whitespace
Line 127:80: E501 line too long (85 > 79 characters)

Line 25:80: E501 line too long (85 > 79 characters)

Line 97:80: E501 line too long (93 > 79 characters)

Line 62:80: E501 line too long (96 > 79 characters)

Line 4:80: E501 line too long (87 > 79 characters)

Line 14:54: W605 invalid escape sequence '\w'
Line 14:80: E501 line too long (85 > 79 characters)
Line 32:67: W605 invalid escape sequence '\w'
Line 32:80: E501 line too long (98 > 79 characters)
Line 47:61: W605 invalid escape sequence '\w'
Line 47:80: E501 line too long (92 > 79 characters)

Line 95:80: E501 line too long (107 > 79 characters)
Line 96:80: E501 line too long (123 > 79 characters)

Line 62:80: E501 line too long (84 > 79 characters)
Line 63:80: E501 line too long (85 > 79 characters)
Line 94:80: E501 line too long (87 > 79 characters)

Line 16:80: E501 line too long (80 > 79 characters)
Line 35:32: W605 invalid escape sequence '#'
Line 161:80: E501 line too long (94 > 79 characters)
Line 221:1: E302 expected 2 blank lines, found 1
Line 250:1: E302 expected 2 blank lines, found 1
Line 254:80: E501 line too long (82 > 79 characters)
Line 354:5: E125 continuation line with same indent as next logical line
Line 370:80: E501 line too long (138 > 79 characters)

Comment last updated at 2022-01-23 09:17:49 UTC

@sourcery-ai sourcery-ai bot mentioned this pull request Jul 13, 2020
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 23, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.96%.

Quality metrics Before After Change
Complexity 15.43 🙂 17.87 🙂 2.44 👎
Method Length 74.55 🙂 79.59 🙂 5.04 👎
Working memory 11.37 😞 12.02 😞 0.65 👎
Quality 53.73% 🙂 50.77% 🙂 -2.96% 👎
Other metrics Before After Change
Lines 5095 4652 -443
Changed files Quality Before Quality After Quality Change
dbplugins/antiflood.py 72.73% 🙂 72.64% 🙂 -0.09% 👎
dbplugins/blacklist.py 70.34% 🙂 70.24% 🙂 -0.10% 👎
dbplugins/filters.py 63.58% 🙂 63.99% 🙂 0.41% 👍
dbplugins/locks.py 35.81% 😞 35.91% 😞 0.10% 👍
dbplugins/snip.py 72.17% 🙂 71.74% 🙂 -0.43% 👎
dbplugins/warns.py 65.67% 🙂 65.38% 🙂 -0.29% 👎
dbplugins/welcome.py 68.29% 🙂 68.15% 🙂 -0.14% 👎
sql_helpers/init.py 95.19% ⭐ 96.84% ⭐ 1.65% 👍
sql_helpers/antiflood_sql.py 82.65% ⭐ 83.08% ⭐ 0.43% 👍
stdplugins/_help.py 73.41% 🙂 67.02% 🙂 -6.39% 👎
stdplugins/account_profile.py 74.35% 🙂 74.21% 🙂 -0.14% 👎
stdplugins/calendar.py 54.78% 🙂 54.67% 🙂 -0.11% 👎
stdplugins/call_admin.py 75.99% ⭐ 73.13% 🙂 -2.86% 👎
stdplugins/coinflip.py 57.74% 🙂 57.61% 🙂 -0.13% 👎
stdplugins/colors.py 59.99% 🙂 59.86% 🙂 -0.13% 👎
stdplugins/count.py 48.01% 😞 28.02% 😞 -19.99% 👎
stdplugins/currency.py 52.09% 🙂 51.98% 🙂 -0.11% 👎
stdplugins/dagd.py 77.86% ⭐ 77.71% ⭐ -0.15% 👎
stdplugins/decide.py 82.46% ⭐ 82.30% ⭐ -0.16% 👎
stdplugins/download.py 15.63% ⛔ 14.54% ⛔ -1.09% 👎
stdplugins/emojis.py 55.70% 🙂 52.36% 🙂 -3.34% 👎
stdplugins/eval.py 45.72% 😞 45.40% 😞 -0.32% 👎
stdplugins/file_converter.py 31.20% 😞 25.23% 😞 -5.97% 👎
stdplugins/fileext.py 69.04% 🙂 68.90% 🙂 -0.14% 👎
stdplugins/fwd.py 74.20% 🙂 76.81% ⭐ 2.61% 👍
stdplugins/get_admin.py 33.60% 😞 34.68% 😞 1.08% 👍
stdplugins/github.py 50.20% 🙂 50.09% 🙂 -0.11% 👎
stdplugins/google.py 55.69% 🙂 47.02% 😞 -8.67% 👎
stdplugins/ifsc.py 67.86% 🙂 67.71% 🙂 -0.15% 👎
stdplugins/imdb.py 51.83% 🙂
stdplugins/invite.py 47.66% 😞 49.98% 😞 2.32% 👍
stdplugins/markdown.py 68.44% 🙂 68.39% 🙂 -0.05% 👎
stdplugins/meaning.py 58.61% 🙂 58.28% 🙂 -0.33% 👎
stdplugins/ninja.py 77.38% ⭐ 77.38% ⭐ 0.00%
stdplugins/ocr.py 70.54% 🙂 73.25% 🙂 2.71% 👍
stdplugins/ping.py 82.99% ⭐ 82.99% ⭐ 0.00%
stdplugins/polls.py 51.00% 🙂 50.63% 🙂 -0.37% 👎
stdplugins/power_tools.py 94.83% ⭐ 91.84% ⭐ -2.99% 👎
stdplugins/promote.py 71.36% 🙂 71.08% 🙂 -0.28% 👎
stdplugins/purge.py 59.14% 🙂 58.77% 🙂 -0.37% 👎
stdplugins/remove.bg.py 56.34% 🙂 55.34% 🙂 -1.00% 👎
stdplugins/sca.py 88.76% ⭐ 88.44% ⭐ -0.32% 👎
stdplugins/screencapture.py 55.02% 🙂 54.96% 🙂 -0.06% 👎
stdplugins/speedtest.py 50.22% 🙂 42.16% 😞 -8.06% 👎
stdplugins/tagall.py 83.41% ⭐ 83.09% ⭐ -0.32% 👎
stdplugins/telegraph.py 28.30% 😞 24.49% ⛔ -3.81% 👎
stdplugins/thumbnail.py 65.98% 🙂 63.57% 🙂 -2.41% 👎
stdplugins/time.py 61.95% 🙂 61.45% 🙂 -0.50% 👎
stdplugins/transfer_channel.py 75.92% ⭐ 75.63% ⭐ -0.29% 👎
stdplugins/translate.py 65.85% 🙂 66.10% 🙂 0.25% 👍
stdplugins/tts.py 48.72% 😞 48.84% 😞 0.12% 👍
stdplugins/typewriter.py 60.77% 🙂 60.88% 🙂 0.11% 👍
stdplugins/ukinti.py 14.53% ⛔ 14.63% ⛔ 0.10% 👍
stdplugins/upload.py 25.68% 😞 21.52% ⛔ -4.16% 👎
stdplugins/urbandictionary.py 64.38% 🙂 64.24% 🙂 -0.14% 👎
stdplugins/watch.py 59.40% 🙂 59.82% 🙂 0.42% 👍
stdplugins/weather.py 67.65% 🙂 67.52% 🙂 -0.13% 👎
stdplugins/whois.py 40.24% 😞 32.44% 😞 -7.80% 👎
stdplugins/xkcd.py 43.19% 😞 23.02% ⛔ -20.17% 👎
uniborg/_core.py 75.06% ⭐ 75.07% ⭐ 0.01% 👍
uniborg/_inline_bot.py 66.34% 🙂 65.28% 🙂 -1.06% 👎
uniborg/uniborg.py 60.02% 🙂 54.12% 🙂 -5.90% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
stdplugins/ukinti.py _ 128 ⛔ 520 ⛔ 21 ⛔ 3.98% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
stdplugins/upload.py _ 73 ⛔ 407 ⛔ 22 ⛔ 5.10% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
stdplugins/count.py stats 37 ⛔ 301 ⛔ 20 ⛔ 14.10% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
stdplugins/download.py _ 25 😞 398 ⛔ 29 ⛔ 14.54% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
dbplugins/locks.py _ 40 ⛔ 233 ⛔ 19 ⛔ 16.80% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.