Statistics overhaul #364
Merged
Statistics overhaul #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For clarity.
Path should be separated by `/` instead of dots. Put `client` first.
I think it makes much more sense. I don't think that having a number of "despawns per second" is useful. Also statistics now represented by `usize`, which avoids casting.
Provided by backend.
According to the official examples, this should be the correct way.
UkoeHB
approved these changes
Nov 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #364 +/- ##
==========================================
+ Coverage 89.69% 89.85% +0.16%
==========================================
Files 44 44
Lines 2445 2484 +39
==========================================
+ Hits 2193 2232 +39
Misses 252 252 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit is a separate change related to it, I would recommend to read one by one.