Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copy forms #2489

Merged
merged 6 commits into from
Feb 16, 2024
Merged

feat: copy forms #2489

merged 6 commits into from
Feb 16, 2024

Conversation

StephanH90
Copy link
Contributor

Description

Allows you to copy forms from the form builder.

image

image

image

image

@StephanH90 StephanH90 requested a review from anehx August 10, 2023 19:23
@anehx
Copy link
Contributor

anehx commented Aug 11, 2023

I'd like to have this button on the form detail view as well (for me it would only need to be there). Normally when using the form builder, I'm already in the form I want to copy (e.g. via form question traversing) so it would be extra effort to navigate to the overview and search for it.

@derrabauke derrabauke force-pushed the feat/copy branch 3 times, most recently from 8e24be4 to ad4597f Compare December 19, 2023 13:18
@derrabauke
Copy link
Contributor

I'd like to have this button on the form detail view as well [...]

Would you like it like this?
image

Mockups welcome 😎

@anehx
Copy link
Contributor

anehx commented Dec 19, 2023

I'd like to have this button on the form detail view as well [...]

Would you like it like this? image

Mockups welcome 😎

Yeah this seems nice. I'd name it just "Copy" but other than that perfect.

Also, IMO this is the only place this is needed. I don't see the use case in the list view..

@derrabauke derrabauke force-pushed the feat/copy branch 2 times, most recently from 2a29cfd to b9d7348 Compare December 19, 2023 15:33
@derrabauke derrabauke force-pushed the feat/copy branch 2 times, most recently from 4e4c195 to a11559f Compare December 20, 2023 15:25
@derrabauke
Copy link
Contributor

derrabauke commented Dec 20, 2023

@anehx any clue why this test error pops up now? Can not reproduce with ember test -s but with ember test. o.O

Also the setupIntl(hooks) is obsolete, cause it's included in the setupRenderingTests. Any reason why that's still there?

@derrabauke
Copy link
Contributor

Seems like calling `setupIntl(hooks, "en") with a locale is fixing it.

@derrabauke
Copy link
Contributor

@anehx this is getting stale. If you find a minute, could you have a look at it again?

Copy link
Contributor

@anehx anehx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @derrabauke & @StephanH90

@anehx anehx merged commit 3b8df3a into projectcaluma:main Feb 16, 2024
57 checks passed
@anehx
Copy link
Contributor

anehx commented Mar 6, 2024

🎉 This PR is included in version 12.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@anehx anehx added the released label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants