feat(validation): list invalid fields for the action-button widget #2488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czosel
reviewed
Aug 10, 2023
czosel
reviewed
Aug 10, 2023
|
@anehx I wasn't able to find any documentation for |
JohnL17
force-pushed
the
display-invalid-fields-for-validation
branch
from
3affaa1
to
d68763b
Compare
anehx
requested changes
Aug 22, 2023
packages/form/addon/components/cf-field/input/action-button.hbs
Outdated
Show resolved
Hide resolved
czosel
force-pushed
the
display-invalid-fields-for-validation
branch
from
1317680
to
7413665
Compare
anehx
requested changes
Aug 22, 2023
packages/form/tests/integration/components/cf-field/input/action-button-test.js
Outdated
Show resolved
Hide resolved
czosel
force-pushed
the
display-invalid-fields-for-validation
branch
from
7413665
to
643ea66
Compare
anehx
approved these changes
Aug 23, 2023
|
🎉 This PR is included in version 12.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility to show invalid fields for the action-button widget.
Depends on projectcaluma/caluma#2050