Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

Replace the 'Refresh' button with a Timer #71

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ThijsRay
Copy link
Contributor

Closes PM-557

Description

Whenever you would start the simulation, the input device would not accurately display the available gaits. This could be fixed by pressing the "Refresh" button. This behaviour can be changed in multiple ways, such as:

  • adding a topic to the gait state machine, that publishes when it is ready and when a change has been made to the state machine
  • retrieving an up-to-date list op possible gaits every x milliseconds

I have chosen the second option, since it ensures that the input device will always reflect the current state of the state machine. Besides that, the gait state machine is being refactored right now in project-march/march#583 and changing behaviour in the state machine would probably result in unnecessary merge conflicts.

Changes

This pull request replaces the manual "Refresh" button with an automatic timer, so you don't have to press the "Refresh" button on startup or when an incorrect state is displayed on the input device.

Testing

@ThijsRay ThijsRay requested a review from a team as a code owner August 27, 2020 14:28
@ThijsRay ThijsRay requested review from Olavhaasie and JorisWeeda and removed request for a team August 27, 2020 14:28
@ThijsRay ThijsRay force-pushed the fix/PM-557-automatically-refresh-RQT-input-device branch from 57503bd to 832ed69 Compare August 27, 2020 14:29
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #71 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #71   +/-   ##
========================================
  Coverage    68.36%   68.36%           
========================================
  Files            9        9           
  Lines          411      411           
  Branches        50       50           
========================================
  Hits           281      281           
  Misses         123      123           
  Partials         7        7           
Flag Coverage Δ
#production 46.32% <ø> (ø)
#test 96.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7db9482...832ed69. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant