feat(allocate-recipient): adds recipient to allocate so its actually …

…used
primitivefinance · Feb 2, 2022 · 4fec0c5 · 4fec0c5
1 parent 886d3d6
commit 4fec0c5
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 7 deletions.
diff --git a/package.json b/package.json
@@ -34,7 +34,7 @@
   },
   "dependencies": {
     "@primitivefi/rmm-core": "^1.0.0-rc.2",
-    "@primitivefi/rmm-manager": "^1.0.0-rc.2",
+    "@primitivefi/rmm-manager": "^1.0.0-rc.3",
     "@primitivefi/rmm-math": "^2.0.0-rc.1",
     "@uniswap/sdk-core": "^3.0.1",
     "shelljs": "0.8.5",

diff --git a/src/peripheryManager.ts b/src/peripheryManager.ts
@@ -410,6 +410,7 @@ export abstract class PeripheryManager extends SelfPermit {
     } else {
       calldatas.push(
         PeripheryManager.INTERFACE.encodeFunctionData('allocate', [
+          recipient,
           pool.poolId,
           pool.risky.address,
           pool.stable.address,

diff --git a/test/PeripheryManager.spec.ts b/test/PeripheryManager.spec.ts
@@ -325,7 +325,15 @@ describe('Periphery Manager', function() {
         delLiquidity,
         slippageTolerance
       })
-      const data = [pool.poolId, pool.risky.address, pool.stable.address, delRisky.raw, delStable.raw, fromMargin]
+      const data = [
+        recipient,
+        pool.poolId,
+        pool.risky.address,
+        pool.stable.address,
+        delRisky.raw,
+        delStable.raw,
+        fromMargin
+      ]
       const decoded = decode('allocate', calldata)
       data.forEach((item, i) => expect(item.toString()).toStrictEqual(decoded[i].toString()))
       expect(value).toBe('0x00')
@@ -346,7 +354,15 @@ describe('Periphery Manager', function() {
         delLiquidity,
         slippageTolerance: parsePercentage(0)
       })
-      const data = [pool.poolId, pool.risky.address, pool.stable.address, delRisky.raw, delStable.raw, fromMargin]
+      const data = [
+        recipient,
+        pool.poolId,
+        pool.risky.address,
+        pool.stable.address,
+        delRisky.raw,
+        delStable.raw,
+        fromMargin
+      ]
       const decoded = decode('allocate', calldata)
       data.forEach((item, i) => expect(item.toString()).toStrictEqual(decoded[i].toString()))
       expect(value).toBe('0x00')
@@ -371,6 +387,7 @@ describe('Periphery Manager', function() {
       })
 
       const allocateData = [
+        recipient,
         wethPool.poolId,
         wethPool.risky.address,
         wethPool.stable.address,

diff --git a/yarn.lock b/yarn.lock
@@ -1745,10 +1745,10 @@
   resolved "https://registry.yarnpkg.com/@primitivefi/rmm-core/-/rmm-core-1.0.0-rc.2.tgz#b30741108d1bc1fe52dd1db32b449cdf7919ffd6"
   integrity sha512-dX58g1WcKfm+nWNZtWtPPMJp1GYe6Py0PxDbc7tvcTEXTYgf2/FHYUjEO9KEKqrFKgPLHh3B2NQrCIiXvHE/DQ==
 
-"@primitivefi/rmm-manager@^1.0.0-rc.2":
-  version "1.0.0-rc.2"
-  resolved "https://registry.yarnpkg.com/@primitivefi/rmm-manager/-/rmm-manager-1.0.0-rc.2.tgz#5740eceafdb17fa7f24b835eb43afaf1e9b3eb95"
-  integrity sha512-hrWxaTE7Zgh29MR2DSjxJcjWC4xRQygg4YtHmvC4rMVwGw3VGRjsXWg3qITUsor8xza0WYMQPFGohYmGT/tKGQ==
+"@primitivefi/rmm-manager@^1.0.0-rc.3":
+  version "1.0.0-rc.3"
+  resolved "https://registry.yarnpkg.com/@primitivefi/rmm-manager/-/rmm-manager-1.0.0-rc.3.tgz#481d6e1dd6a0edad8d163a7c2ae4271e201c9b84"
+  integrity sha512-orXVdIF9wdvoRl67Os8Goz0OV9cWV87a7EsV/izb84V+yPVWDrNTQcbQbxDEl10Zl+NqX0FbOSy8TLj8HnySdw==
   dependencies:
     "@openzeppelin/contracts" "^4.1.0"
     "@primitivefi/rmm-core" "^1.0.0-rc.2"