Refactor: Banner 컴포넌트 내용 이미지로 수정

- 텍스트를 props로 주던것을 이미지로 대체함
prgrms-fe-devcourse · Sep 30, 2024 · 9a796c4 · 9a796c4
1 parent c15c118
commit 9a796c4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 29 deletions.
diff --git a/src/assets/imgs/banner.png b/src/assets/imgs/banner.png
diff --git a/src/components/Banner/index.tsx b/src/components/Banner/index.tsx
@@ -1,28 +1,15 @@
-import { H24, P16 } from '@/components/Text';
 import * as S from './styles';
-import { CommonResponseType } from '@/types/apis';
 
 interface BannerProps {
-  bInfo: Pick<
-    CommonResponseType,
-    'mt20id' | 'prfnm' | 'poster' | 'prfplcnm' | 'pcseguidance' | 'prfpdfrom' | 'prfpdto'
-  >;
+  src: string;
   width?: number;
   height?: number;
 }
 
-export const Banner = ({ bInfo, width = 100, height = 30 }: BannerProps) => {
+export const Banner = ({ src, width = 100, height = 30 }: BannerProps) => {
   return (
     <S.Banner width={width} height={height}>
-      <img src={bInfo.poster} alt="banner"></img>
-      <S.Text>
-        <H24>{bInfo.prfnm}</H24>
-        <P16>{bInfo.prfplcnm}</P16>
-        <P16>{bInfo.pcseguidance}</P16>
-        <P16>
-          {bInfo.prfpdfrom} - {bInfo.prfpdto}
-        </P16>
-      </S.Text>
+      <img src={src} alt="banner"></img>
     </S.Banner>
   );
 };
diff --git a/src/components/Banner/styles.ts b/src/components/Banner/styles.ts
@@ -6,7 +6,6 @@ export const Banner = styled.div<{ width: number; height: number }>`
   padding-top: ${({ height }) => height}%;
   max-width: 1280px;
   margin: auto;
-  overflow: hidden;
 
   & > img {
     position: absolute;
@@ -21,15 +20,3 @@ export const Banner = styled.div<{ width: number; height: number }>`
     padding-top: 300px;
   }
 `;
-export const Text = styled.div`
-  position: absolute;
-  top: 10%;
-  left: 10%;
-  & > h2 {
-    margin-bottom: 5rem;
-  }
-  & > p {
-    margin-bottom: 1rem;
-    width: 80%;
-  }
-`;