-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 check for None before setting n_jobs
to nb logical CPUs
#126
Conversation
CodSpeed Performance ReportMerging #126 will degrade performances by 97.95%Comparing Summary
Benchmarks breakdown
|
The tsfel LPCC - bug - for which we provided a hotfix is fixed in https://github.com/fraunhoferportugal/tsfel/releases/tag/v0.1.4 |
Ready for review @jvdd! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Following the merger of #118 a bug slipped into tsflex.
Parsing the
n_jobs
ignored user-specified values (i.e. integers) and always selected the number of logical cores. As such, it was impossible for users to manage the number of jobs...