Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Python 3.12 support #116

Merged
merged 18 commits into from
Feb 14, 2024
Merged

🚀 Python 3.12 support #116

merged 18 commits into from
Feb 14, 2024

Conversation

jvdd
Copy link
Member

@jvdd jvdd commented Feb 8, 2024

  • update tests as numpy its np.min and np.max are not anymore amin and amax

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3620a67) 98.03% compared to head (a608a1f) 98.04%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   98.03%   98.04%           
=======================================
  Files          23       23           
  Lines        1376     1382    +6     
=======================================
+ Hits         1349     1355    +6     
  Misses         27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 8, 2024

CodSpeed Performance Report

Merging #116 will improve performances by 38.54%

Comparing py3.12 (a608a1f) with main (3620a67)

Summary

⚡ 179 improvements
✅ 94 untouched benchmarks

🆕 108 new benchmarks
⁉️ 108 (👁 108) dropped benchmarks

Benchmarks breakdown

Benchmark main py3.12 Change
👁 test_single_series_feature_collection[15s-10s-1-amax] 93.9 ms N/A N/A
👁 test_single_series_feature_collection[15s-10s-1-amin] 93.9 ms N/A N/A
🆕 test_single_series_feature_collection[15s-10s-1-max] N/A 80 ms N/A
test_single_series_feature_collection[15s-10s-1-mean] 136.4 ms 122.4 ms +11.42%
test_single_series_feature_collection[15s-10s-1-median] 317.8 ms 264.1 ms +20.31%
🆕 test_single_series_feature_collection[15s-10s-1-min] N/A 80 ms N/A
test_single_series_feature_collection[15s-10s-1-sum] 95.2 ms 81.1 ms +17.36%
👁 test_single_series_feature_collection[15s-10s-2-amax] 93.9 ms N/A N/A
👁 test_single_series_feature_collection[15s-10s-2-amin] 93.9 ms N/A N/A
🆕 test_single_series_feature_collection[15s-10s-2-max] N/A 80 ms N/A
test_single_series_feature_collection[15s-10s-2-mean] 136.4 ms 122.4 ms +11.45%
test_single_series_feature_collection[15s-10s-2-median] 317.9 ms 264.2 ms +20.35%
🆕 test_single_series_feature_collection[15s-10s-2-min] N/A 80 ms N/A
test_single_series_feature_collection[15s-10s-2-sum] 95.2 ms 81.1 ms +17.33%
👁 test_single_series_feature_collection[15s-10s-4-amax] 93.9 ms N/A N/A
👁 test_single_series_feature_collection[15s-10s-4-amin] 93.9 ms N/A N/A
🆕 test_single_series_feature_collection[15s-10s-4-max] N/A 80 ms N/A
test_single_series_feature_collection[15s-10s-4-mean] 136.4 ms 122.4 ms +11.4%
test_single_series_feature_collection[15s-10s-4-median] 317.8 ms 264.4 ms +20.18%
🆕 test_single_series_feature_collection[15s-10s-4-min] N/A 80 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Copy link
Member Author

@jvdd jvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvdd jvdd merged commit e0dcb72 into main Feb 14, 2024
22 checks passed
@jvdd jvdd mentioned this pull request Feb 14, 2024
@jvdd jvdd deleted the py3.12 branch August 24, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants