-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat: Feature extraction with an identifier #109
✨ feat: Feature extraction with an identifier #109
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 97.91% 98.02% +0.11%
==========================================
Files 23 23
Lines 1249 1370 +121
==========================================
+ Hits 1223 1343 +120
- Misses 26 27 +1 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #109 will degrade performances by 55.47%Comparing Summary
Benchmarks breakdown
|
…om/NielsPraet/tsflex into feat/identifier-feature-extraction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Waiting for your review @jonasvdd
@jonasvdd ready to be merged i.m.o. |
Closes #63
Adds 2 arguments to the
FeatureCollection.calculate
method:group_by_all
: creates groups that contains all rows corresponding to the group valuedf.groupby(group_by_all)
asdata
to the.calculate
method -> (which is now also a valid input for thedata
argument 🎉)group_by_consecutive
: creates groups that contain consecutive rows for the group valueBoth grouped feature extraction approaches ignore NaNs in the
group_by
column.Limitations: currently restricted to grouping on only a single column.
TODOs