fix(#286): vasm output suppressed during build

prb28 · Feb 5, 2024 · 299bc74 · 299bc74
1 parent 7fee019
commit 299bc74
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+### [1.8.8] - pre-release
+- [Issue #286](https://github.com/prb28/vscode-amiga-assembly/issues/286) vasm output suppressed during build since 1.8.4
+
 ### [1.8.7] - pre-release
 - [Issue #291](https://github.com/prb28/vscode-amiga-assembly/issues/291) Compatibility issue with vscode 1.86.0
 

diff --git a/src/execHelper.ts b/src/execHelper.ts
@@ -37,7 +37,8 @@ export class ExecutorHelper {
         return new Promise((resolve, reject) => {
             const options: cp.ExecFileOptionsWithBufferEncoding = {
                 env: env,
-                encoding: null
+                encoding: null,
+                shell: true
             };
             if (cwd) {
                 options.cwd = cwd;
@@ -75,7 +76,13 @@ export class ExecutorHelper {
 
                     let ret: ICheckResult[] = [];
                     if (stdout || (useStdErr && stderr)) {
-                        const text = ((useStdErr && stderr) ? stderr : stdout).toString();
+                        let text = ""
+                        if (stdout) {
+                            text += stdout.toString()
+                        }
+                        if (useStdErr && stderr) {
+                            text += stderr.toString()
+                        }
                         if (logEmitter) {
                             logEmitter.fire(text + '\r\n');
                         }