🐛 Do not generate violations when there are no incidents (konveyor#281)

Closes konveyor#278

---------

Signed-off-by: Parthiba-Hazra <parthibahazra02@gmail.com>

engine/engine.go

@@ -173,7 +173,7 @@ func (r *ruleEngine) RunRules(ctx context.Context, ruleSets []RuleSet, selectors
 						if rs, ok := mapRuleSets[response.RuleSetName]; ok {
 							rs.Errors[response.Rule.RuleID] = response.Err.Error()
 						}
-					} else if response.ConditionResponse.Matched {
+					} else if response.ConditionResponse.Matched && len(response.ConditionResponse.Incidents) > 0 {
 						violation, err := r.createViolation(response.ConditionResponse, response.Rule)
 						if err != nil {
 							r.logger.Error(err, "unable to create violation from response")

provider/provider.go

@@ -431,13 +431,25 @@ func (p *ProviderCondition) Evaluate(ctx context.Context, log logr.Logger, condC
 		}
 		incidents = append(incidents, i)
 	}
+
+	// If there are no incidents, don't generate any violations
+	if len(incidents) == 0 && len(resp.Incidents)-len(incidents) > 0 {
+		log.V(5).Info("filtered out all incidents based on dep label selector", "filteredOutCount", len(resp.Incidents)-len(incidents))
+		return engine.ConditionResponse{
+			Matched: resp.Matched,
+		}, nil
+	}
+
 	cr := engine.ConditionResponse{
 		Matched:         resp.Matched,
 		TemplateContext: resp.TemplateContext,
 		Incidents:       incidents,
 	}
 
 	log.V(8).Info("condition response", "ruleID", p.Rule.RuleID, "response", cr, "cap", p.Capability, "conditionInfo", p.ConditionInfo, "client", p.Client)
+	if len(resp.Incidents)-len(incidents) > 0 {
+		log.V(5).Info("filtered out incidents based on dep label selector", "filteredOutCount", len(resp.Incidents)-len(incidents))
+	}
 	return cr, nil
 
 }