Provide partial test suite for header validation #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Consensus code PR: IntersectMBO/ouroboros-consensus#1285 |
|
Rebase on top of |
AndrewWestberg
approved these changes
Oct 26, 2024
abailly
force-pushed
the
abailly/test-header-validation
branch
from
c3991fe
to
c219853
Compare
AndrewWestberg
requested changes
Oct 28, 2024
* add JSON-formatted test vectors file, to be expanded to cover more edge cases as needed * add integration tests to check validation logic against those test cases * fix some minor issues in validation code following introduction of those tests
abailly
force-pushed
the
abailly/test-header-validation
branch
from
c219853
to
3f39398
Compare
|
@AndrewWestberg Can we merge this? It's been a while... |
AndrewWestberg
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon @AndrewWestberg's work on Praos headers validation, adding more tests in the form of JSON-formatted pairs of a context and a header, which may or may not be valid. A single test function loads the test vectors and iterates through the various headers, calling validation code and verifying the result. These tests increase code coverage from ~75% to ~95%.
In the course of writing these tests, I found a few minor issues I fixed in the validation code:
cvalue (ran the benchmarks locally and did not notice any significant impact), because of first point abovepanicfrom underflowThere's more work that needs to be done to cover more of the validation process, which I plan to add in another PR: