Merge pull request #641 from praekeltfoundation/update-gobberish-dete…

…ction-function update gibberish response
praekeltfoundation · Oct 22, 2024 · 292612a · 292612a
2 parents 46c61c1 + 7b0fc7f
commit 292612a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 21 deletions.
diff --git a/aaq/tests/helpers.py b/aaq/tests/helpers.py
@@ -109,15 +109,8 @@ def post_search(self, request):
 
     def post_search_return_empty(self, request):
         resp_body = {
-            "debug_info": {"example": "debug-info"},
-            "feedback_secret_key": "secret-key-12345-abcde",
-            "llm_response": None,
-            "query_id": 1,
-            "search_results": {
-                "status": 400,
-                "error": {"detail": "Gibberish text detected: gyugsywgshfsthg"},
-            },
-            "state": "final",
+            "status": 400,
+            "error": {"detail": "Gibberish text detected: vyjhftgdfdgt"},
         }
 
         return (200, {}, json.dumps(resp_body))

diff --git a/aaq/tests/test_utils.py b/aaq/tests/test_utils.py
@@ -133,7 +133,4 @@ def test_search_gibberish(self):
 
         assert response.data == {
             "message": "Gibberish Detected",
-            "body": {},
-            "feedback_secret_key": "secret-key-12345-abcde",
-            "query_id": 1,
         }
diff --git a/aaq/utils.py b/aaq/utils.py
@@ -36,21 +36,17 @@ def search(query_text, generate_llm_response, query_metadata):
     response = requests.request("POST", url, json=payload, headers=headers)
     response.raise_for_status()
 
-    query_id = response.json()["query_id"]
-    feedback_secret_key = response.json()["feedback_secret_key"]
-    search_results = response.json()["search_results"]
-
-    if "error" in search_results:
-        error_detail = search_results["error"].get("detail", "")
+    if "error" in response.json():
+        error_detail = response.json()["error"].get("detail", "")
         if "Gibberish text detected" in error_detail:
             json_msg = {
                 "message": "Gibberish Detected",
-                "body": {},
-                "feedback_secret_key": feedback_secret_key,
-                "query_id": query_id,
             }
             return Response(json_msg, status=status.HTTP_200_OK)
 
+    query_id = response.json()["query_id"]
+    feedback_secret_key = response.json()["feedback_secret_key"]
+    search_results = response.json()["search_results"]
     json_msg = {}
     body_content = {}
     message_titles = []