Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neo2: Fix layer 2 lock #1737

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

gifti258
Copy link
Contributor

Presumably with the newest version, layer 2 lock required to press both shift keys for about at least 2 seconds.

@tekezo
Copy link
Member

tekezo commented Oct 20, 2024

@gifti258
Thank you for the PR.
Upon checking the content, is this change is more appropriate?

@@ -231,16 +231,24 @@ function rules() {
         {
           type: 'basic',
           from: { key_code: 'left_shift', modifiers: { mandatory: ['right_shift'], optional: ['caps_lock'] } },
-          to: [{ key_code: 'caps_lock' }],
+          to: [
+            {
+              key_code: 'caps_lock',
+              hold_down_milliseconds: 200,
+            },
+            {
+              key_code: 'vk_none',
+            },
+          ],
           to_if_alone: [{ key_code: 'left_shift' }]
         },
         {

Presumably with the newest version, layer 2 lock required to press both
shift keys for about at least 2 seconds.
@gifti258
Copy link
Contributor Author

simultaneous is still needed, but I appreciate your suggestion of hold_down_milliseconds, which makes layer 2 lock work even better!

@tekezo tekezo merged commit 677d41a into pqrs-org:main Oct 22, 2024
1 check passed
@tekezo
Copy link
Member

tekezo commented Oct 22, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants