Allow for other GORM databases #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserve current SQLite config options while adding a section for DSN based connections. Currently only adding PostgreSQL, however, any GORM driver should be available to be added. config.yaml updated to show examples of both ways to specify database connections.
Only need the ID/Message_ID column. The tenant_id, queue_id columns are not index and therefore PostgreSQL will not process as a foreign key.
Extend transaction to include select statement to allow for FOR UPDATE/SKIP LOCKED clauses to properly dequeue rows with PostgreSQL.
Move parameter addition into proper if clause. SQLite apparantly ignores extra parameters where other databases are more strict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to use PostgreSQL or other GORM drivers for the database