fix: ignore stale checks from closed PRs #352
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dghubble
reviewed
Oct 27, 2024
There was a problem hiding this comment.
In other orgs, this action runs alongside push triggered check runs, which don't have a PR associated with them. So I don't think the pull_requests field is always present. I think this would error in those cases and needs a condition to say if there is no pull_request continue as usual.
You can probably check this by making a push triggered change and looking at the run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that checks are only considered if they match an open PR. This is useful for scenarios when a branch name changes but the commit SHA stays the same.