Stretch text fields for ISIN, Ticker and WKN in SecurityMasterDataPage #3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buchen
added a commit
that referenced
this pull request
Sep 2, 2023
Issue: #3532 Issue: https://forum.portfolio-performance.info/t/eingabefeld-symbol-in-der-eingabemaske-verlangern/24916 Co-authored-by: OnkelDok <90478568+OnkelDok@users.noreply.github.com> Co-authored-by: Andreas Buchen <andreas.buchen@gmail.com>
|
Hi @OnkelDok, thanks for picking this up - it is one of those "paper cuts". It is super annoying that the field is not very long - but it is also super easy to fix (as opposed to "just" support bonds). Personally, I did not like the stretching that much. It fills up the dialog unnecessary with a field which typically contains 10 characters at most. I now increased the width to 30 characters. That should be more than enough. 
Andreas. |
|
(I put the two of us as authors of course) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://forum.portfolio-performance.info/t/eingabefeld-symbol-in-der-eingabemaske-verlangern/24916
EDIT:
After initial commit I realized that with my change of the ISIN textinput I removed the validation of the ISIN value.
@buchen: If you generally would accept the stretching, then I will find a way to have both: stretch and validation. Just let me know.