Implemented QC for three mouse demographic models #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrelharp
force-pushed
the
mouse_demog_QC
branch
from
bd4360e
to
c6aab0d
Compare
|
I've rebased this so the tests run, but it looks good if the tests pass. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1531 +/- ##
=======================================
Coverage 99.85% 99.86%
=======================================
Files 127 128 +1
Lines 4260 4300 +40
Branches 591 594 +3
=======================================
+ Hits 4254 4294 +40
Misses 3 3
Partials 3 3
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a thorough manual inspection of the code, I now implemented the QC for the three demographic models. See #1528.