Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segmented_button: support variable-width buttons when horizontal width is Shrink #282

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

mmstick
Copy link
Member

@mmstick mmstick commented Jan 25, 2024

Once this is merged, I will make PRs for cosmic-edit and cosmic-term to utilize the new features.

When the width of a horizontal segmented button is set to Shrink:

  • Enable variable width button widths
  • Supports tab pagination when there is too little space

Also makes the following improvements:

  • Drawing should now require less CPU
  • Fix for drawing in vertical layout

Remaining issues to resolve

  • Integrate better with a tab add button
  • Fix overlapping layout when Fill width when pagination is enabled

@mmstick mmstick requested a review from a team January 26, 2024 15:25
@mmstick mmstick marked this pull request as ready for review January 26, 2024 15:25
@mmstick mmstick merged commit d5b2a2e into master Jan 26, 2024
10 checks passed
@mmstick mmstick deleted the segmented-shrink branch January 26, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants