Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sctk: Add support for ext-session-lock protocol #71

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Oct 20, 2023

The example creates a session lock surface, but doesn't currently show the contents of the surface correctly. Still figuring that part out. Then some of the smaller details will need some care (making sure to not exit without a round trip, handling the compositor refusing to create lock, etc.)

@ids1024 ids1024 force-pushed the sctk-session-lock branch 8 times, most recently from 4b9cf87 to 5d2e29b Compare October 27, 2023 01:17
@ids1024 ids1024 force-pushed the sctk-session-lock branch 3 times, most recently from 175ea15 to 0cc1494 Compare November 15, 2023 23:28
@ids1024 ids1024 changed the title WIP session lock support sctk: Add support for ext-session-lock protocol Nov 15, 2023
@ids1024 ids1024 marked this pull request as ready for review November 15, 2023 23:32
@ids1024 ids1024 requested a review from a team November 15, 2023 23:32
@ids1024
Copy link
Member Author

ids1024 commented Nov 15, 2023

I've figured out the remaining issues here and in the compositor, and cleaned up a few things. This seems to be working pretty well now with pop-os/cosmic-greeter#2.

Copy link
Member

@jackpot51 jackpot51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@jackpot51 jackpot51 merged commit 9d65c57 into master Nov 15, 2023
18 of 20 checks passed
@jackpot51 jackpot51 deleted the sctk-session-lock branch November 15, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants