feat(renderer): definable default color for symbolic icons #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, this is the same as the text color for best visibility.
Changes required to support the icon_color renderer setting.
Changes required to support the icon_color renderer setting.
wash2
approved these changes
Sep 7, 2023
mmstick
force-pushed
the
icon-color
branch
2 times, most recently
from
20ccd55
to
1f8fe03
Compare
|
Added fix for pop-os/libcosmic#154 |
wash2
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new field to the renderer style to support defining a default icon color for symbolic icons. By default, this color will be set to the same value as the text color for maximum visibility. The color may be overridden by the button or container that it is placed in. Icons marked as symbolic will opt into this color if no color was defined.
Merge with pop-os/libcosmic#150