fix(sctk): broadcast events after update

when broadcasting events for no specific surface, it should be done after update so that the runtime subscription is current
pop-os · Feb 23, 2024 · 8c2431d · 8c2431d
1 parent d2dc827
commit 8c2431d
Showing 1 changed file with 38 additions and 30 deletions.
diff --git a/sctk/src/application.rs b/sctk/src/application.rs
@@ -926,36 +926,7 @@ where
                 {
                     continue;
                 }
-
-                let mut i = 0;
-                while i < sctk_events.len() {
-                    let remove = matches!(
-                        sctk_events[i],
-                        SctkEvent::NewOutput { .. }
-                            | SctkEvent::UpdateOutput { .. }
-                            | SctkEvent::RemovedOutput(_)
-                            | SctkEvent::SessionLocked
-                            | SctkEvent::SessionLockFinished
-                            | SctkEvent::SessionUnlocked
-                            | SctkEvent::PopupEvent { .. }
-                            | SctkEvent::LayerSurfaceEvent { .. }
-                            | SctkEvent::WindowEvent { .. }
-                    );
-                    if remove {
-                        let event = sctk_events.remove(i);
-                        for native_event in event.to_native(
-                            &mut mods,
-                            &surface_ids,
-                            &destroyed_surface_ids,
-                        ) {
-                            runtime.broadcast(native_event, Status::Ignored);
-                        }
-                    } else {
-                        i += 1;
-                    }
-                }
-
-                if surface_ids.is_empty() && !messages.is_empty() {
+                if surface_ids.is_empty() {
                     // Update application
                     let pure_states: HashMap<_, _> =
                         ManuallyDrop::into_inner(interfaces)
@@ -1242,6 +1213,43 @@ where
                     redraw_pending = false;
                 }
 
+                let mut i = 0;
+                while i < sctk_events.len() {
+                    let remove = matches!(
+                        sctk_events[i],
+                        SctkEvent::NewOutput { .. }
+                            | SctkEvent::UpdateOutput { .. }
+                            | SctkEvent::RemovedOutput(_)
+                            | SctkEvent::SessionLocked
+                            | SctkEvent::SessionLockFinished
+                            | SctkEvent::SessionUnlocked
+                            | SctkEvent::PopupEvent { .. }
+                            | SctkEvent::LayerSurfaceEvent { .. }
+                            | SctkEvent::WindowEvent { .. }
+                    );
+                    if remove {
+                        let event = sctk_events.remove(i);
+                        if matches!(
+                            &event,
+                            SctkEvent::NewOutput { .. }
+                                | SctkEvent::UpdateOutput { .. }
+                                | SctkEvent::RemovedOutput(_)
+                        ) {
+                            println!("Output event...");
+                            // dbg!(&event);
+                        }
+                        for native_event in event.to_native(
+                            &mut mods,
+                            &surface_ids,
+                            &destroyed_surface_ids,
+                        ) {
+                            runtime.broadcast(native_event, Status::Ignored);
+                        }
+                    } else {
+                        i += 1;
+                    }
+                }
+
                 sctk_events.clear();
                 // clear the destroyed surfaces after they have been handled
                 destroyed_surface_ids.clear();