Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Support for touch input #199

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP Support for touch input #199

wants to merge 1 commit into from

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Jun 12, 2024

Requires pop-os/xdg-shell-wrapper#22.

Seems to be working now. And panel applets already support touch, since it was added to iced-sctk.

I want to see if update_pointer and this touch_under can be cleanup up and deduplicated a bit though... as well as a bit more testing.

@wash2
Copy link
Collaborator

wash2 commented Jun 12, 2024

This looks pretty good to me. I'm not sure how touch should be handled for auto-hiding panels though, and also stacked auto-hiding panels, which are a bit complicated. We might want to add a method to the space trait for down / up, that can be used like how enter / leave are used.

@ids1024
Copy link
Member Author

ids1024 commented Jun 13, 2024

Yeah. For auto-hiding panels, probably touches within a certain number of pixels of the edge of the screen should show the panel, but I'm not sure there's a way to do that without having a surface that will also intercept mouse events? Instead of letting them go to the window behind the dock.

Edit: I assume we can't reliably detect a swipe from a screen edge handling touches just on a border 1 px wide. At least not on all screens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants