Add config option to show additional context menu actions

pop-os · Aug 15, 2024 · e5f59a2 · e5f59a2
1 parent f24cbaa
commit e5f59a2
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 2 deletions.
diff --git a/i18n/de/cosmic_files.ftl b/i18n/de/cosmic_files.ftl
@@ -128,7 +128,10 @@ properties = Eigenschaften
 ## Einstellungen
 settings = Einstellungen
 settings-tab = Tab
+settings-optional-context-menu-actions = Optionale Aktionen im Kontextmenü
+settings-optional-context-menu-actions-description = Weitere Aktionen im Menü anzeigen. Tastenkürzel können auch für ausgeblendete Aktionen verwendet werden.
 settings-show-hidden = Versteckte Dateien anzeigen
+settings-show-delete-permanently = Dauerhaft löschen
 default-view = Standardansicht
 icon-size-list = Symbolgröße (Liste)
 icon-size-grid = Symbolgröße (Raster)

diff --git a/i18n/en/cosmic_files.ftl b/i18n/en/cosmic_files.ftl
@@ -130,7 +130,10 @@ show-details = Show details
 ## Settings
 settings = Settings
 settings-tab = Tab
+settings-optional-context-menu-actions = Optional Context Menu Actions
+settings-optional-context-menu-actions-description = Show more actions in the menus. Keyboard shortcuts can be used even if the actions are not shown.
 settings-show-hidden = Show hidden files
+settings-show-delete-permanently = Permanently delete
 default-view = Default view
 icon-size-list = Icon size (list)
 icon-size-grid = Icon size (grid)

diff --git a/src/app.rs b/src/app.rs
@@ -956,6 +956,24 @@ impl App {
                     )
                 })
                 .into(),
+            widget::settings::view_section(fl!("settings-optional-context-menu-actions"))
+                .add(widget::text(fl!(
+                    "settings-optional-context-menu-actions-description"
+                )))
+                .add({
+                    let tab_config = self.config.tab.clone();
+                    widget::settings::item::builder(fl!("settings-show-delete-permanently"))
+                        .toggler(
+                            tab_config.show_delete_permanently,
+                            move |show_delete_permanently| {
+                                Message::TabConfig(TabConfig {
+                                    show_delete_permanently,
+                                    ..tab_config
+                                })
+                            },
+                        )
+                })
+                .into(),
         ])
         .into()
     }

diff --git a/src/config.rs b/src/config.rs
@@ -131,6 +131,8 @@ pub struct TabConfig {
     pub sort_direction: bool,
     /// Icon zoom
     pub icon_sizes: IconSizes,
+    /// Show delete permanently context menu item
+    pub show_delete_permanently: bool,
 }
 
 impl Default for TabConfig {
@@ -142,6 +144,7 @@ impl Default for TabConfig {
             sort_name: HeadingOptions::Name,
             sort_direction: true,
             icon_sizes: IconSizes::default(),
+            show_delete_permanently: false,
         }
     }
 }

diff --git a/src/menu.rs b/src/menu.rs
@@ -59,6 +59,7 @@ pub fn context_menu<'a>(
     let TabConfig {
         sort_name,
         sort_direction,
+        show_delete_permanently,
         ..
     } = tab.config;
     let sort_item = |label, variant| {
@@ -121,8 +122,11 @@ pub fn context_menu<'a>(
                 children.push(menu_item(fl!("add-to-sidebar"), Action::AddToSidebar).into());
                 children.push(container(horizontal_rule(1)).padding([0, 8]).into());
                 children.push(menu_item(fl!("move-to-trash"), Action::MoveToTrash).into());
-                children
-                    .push(menu_item(fl!("permanently-delete"), Action::PermanentlyDelete).into());
+                if show_delete_permanently {
+                    children.push(
+                        menu_item(fl!("permanently-delete"), Action::PermanentlyDelete).into(),
+                    );
+                }
             } else {
                 //TODO: need better designs for menu with no selection
                 //TODO: have things like properties but they apply to the folder?