-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(graphics): only show the button if the graphics can be switched #174
Conversation
Confirmed this does make the button unclickable (which means it also doesn't highlight on mouse-over) on an integrated system. The icon and the word |
If there are no modes available to switch, then the applet shouldn't show on the panel. The applet should only be present for systems where the modes are available. |
Ok this should exit now when the graphics are not switchable |
This now causes the button to not show up on an integrated system. This currently does cause an extra bit of space to appear between the surrounding icons where the applet is positioned (possibly just 1px, looking at the code?) See below for a comparison of the Graphics applet being in two positions (open them in tabs and flip between them to see the difference): The space is also possible to find by moving the mouse across all the icons and seeing where there's a larger gap between the hover states. |
Hmm ok Maybe the panel is not updating the layout after it exits? I'll test it and maybe make a fix for the panel. |
pop-os/cosmic-panel#79 should fix the gap. It wasn't removing the spacing for the removed applet after it exited. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should fix #173. This makes the button press-able if the graphics can be switched.