fix: update shlex #113
jackpot51Annotations
10 warnings
|
unused import: `self`:
cosmic-app-list/src/app.rs#L14
warning: unused import: `self`
--> cosmic-app-list/src/app.rs:14:29
|
14 | use cosmic::cosmic_config::{self, Config, CosmicConfigEntry};
| ^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
unused import: `cosmic::iced_core::window::Icon`:
cosmic-app-list/src/app.rs#L27
warning: unused import: `cosmic::iced_core::window::Icon`
--> cosmic-app-list/src/app.rs:27:5
|
27 | use cosmic::iced_core::window::Icon;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `std::borrow::Cow`:
cosmic-app-list/src/app.rs#L55
warning: unused import: `std::borrow::Cow`
--> cosmic-app-list/src/app.rs:55:5
|
55 | use std::borrow::Cow;
| ^^^^^^^^^^^^^^^^
|
|
unused imports: `hash::Hash`, `thread::JoinHandle`:
cosmic-app-list/src/wayland_subscription.rs#L15
warning: unused imports: `hash::Hash`, `thread::JoinHandle`
--> cosmic-app-list/src/wayland_subscription.rs:15:23
|
15 | use std::{fmt::Debug, hash::Hash, thread::JoinHandle};
| ^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^
|
|
variant `Exit` is never constructed:
cosmic-app-list/src/wayland_subscription.rs#L102
warning: variant `Exit` is never constructed
--> cosmic-app-list/src/wayland_subscription.rs:102:5
|
99 | pub enum ToplevelRequest {
| --------------- variant in this enum
...
102 | Exit,
| ^^^^
|
= note: `ToplevelRequest` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
cosmic-applet-audio/src/mpris_subscription.rs#L168
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> cosmic-applet-audio/src/mpris_subscription.rs:168:81
|
168 | let media_players = mpris2_zbus::media_player::MediaPlayer::new_all(&conn)
| ^^^^^ help: change this to: `conn`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
cosmic-applet-audio/src/mpris_subscription.rs#L227
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> cosmic-applet-audio/src/mpris_subscription.rs:227:87
|
227 | let players = mpris2_zbus::media_player::MediaPlayer::new_all(&conn)
| ^^^^^ help: change this to: `conn`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
cosmic-applet-audio/src/mpris_subscription.rs#L253
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> cosmic-applet-audio/src/mpris_subscription.rs:253:15
|
253 | a.cmp(&b)
| ^^ help: change this to: `b`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
very complex type used. Consider factoring parts into `type` definitions:
cosmic-applet-audio/src/pulse.rs#L22
warning: very complex type used. Consider factoring parts into `type` definitions
--> cosmic-applet-audio/src/pulse.rs:22:24
|
22 | pub static FROM_PULSE: Lazy<Mutex<Option<(mpsc::Receiver<Message>, mpsc::Sender<Message>)>>> =
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
this function has too many arguments (9/7):
cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs#L24
warning: this function has too many arguments (9/7)
--> cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs:24:1
|
24 | // #[dbus_proxy(
25 | || interface = "org.freedesktop.Notifications",
26 | || default_service = "org.freedesktop.Notifications",
27 | || default_path = "/org/freedesktop/Notifications"
28 | || )]
| ||__- in this procedural macro expansion
... |
49 | | expire_timeout: i32,
50 | | ) -> zbus::Result<u32>;
| |___________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
= note: this warning originates in the attribute macro `dbus_proxy` (in Nightly builds, run with -Z macro-backtrace for more info)
|