Skip to content

fix: update shlex

fix: update shlex #112

Triggered via pull request January 22, 2024 22:00
Status Success
Total duration 2m 40s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
unused import: `self`: cosmic-app-list/src/app.rs#L14
warning: unused import: `self` --> cosmic-app-list/src/app.rs:14:29 | 14 | use cosmic::cosmic_config::{self, Config, CosmicConfigEntry}; | ^^^^ | = note: `#[warn(unused_imports)]` on by default
unused import: `cosmic::iced_core::window::Icon`: cosmic-app-list/src/app.rs#L27
warning: unused import: `cosmic::iced_core::window::Icon` --> cosmic-app-list/src/app.rs:27:5 | 27 | use cosmic::iced_core::window::Icon; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `std::borrow::Cow`: cosmic-app-list/src/app.rs#L55
warning: unused import: `std::borrow::Cow` --> cosmic-app-list/src/app.rs:55:5 | 55 | use std::borrow::Cow; | ^^^^^^^^^^^^^^^^
unused imports: `hash::Hash`, `thread::JoinHandle`: cosmic-app-list/src/wayland_subscription.rs#L15
warning: unused imports: `hash::Hash`, `thread::JoinHandle` --> cosmic-app-list/src/wayland_subscription.rs:15:23 | 15 | use std::{fmt::Debug, hash::Hash, thread::JoinHandle}; | ^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^
variant `Exit` is never constructed: cosmic-app-list/src/wayland_subscription.rs#L102
warning: variant `Exit` is never constructed --> cosmic-app-list/src/wayland_subscription.rs:102:5 | 99 | pub enum ToplevelRequest { | --------------- variant in this enum ... 102 | Exit, | ^^^^ | = note: `ToplevelRequest` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default
variants `SetPairable` and `SetDiscoverable` are never constructed: cosmic-applet-bluetooth/src/bluetooth.rs#L121
warning: variants `SetPairable` and `SetDiscoverable` are never constructed --> cosmic-applet-bluetooth/src/bluetooth.rs:121:5 | 119 | pub enum BluerRequest { | ------------ variants in this enum 120 | SetBluetoothEnabled(bool), 121 | SetPairable(bool), | ^^^^^^^^^^^ 122 | SetDiscoverable(bool), | ^^^^^^^^^^^^^^^ | = note: `BluerRequest` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default
non-canonical implementation of `partial_cmp` on an `Ord` type: cosmic-applet-bluetooth/src/bluetooth.rs#L188
warning: non-canonical implementation of `partial_cmp` on an `Ord` type --> cosmic-applet-bluetooth/src/bluetooth.rs:188:1 | 188 | / impl PartialOrd for BluerDevice { 189 | | fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> { | | _______________________________________________________________________- 190 | || match self.status.cmp(&other.status) { 191 | || std::cmp::Ordering::Equal => { 192 | || Some(self.name.to_lowercase().cmp(&other.name.to_lowercase())) ... || 195 | || } 196 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 197 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default
this function has too many arguments (9/7): cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs#L24
warning: this function has too many arguments (9/7) --> cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs:24:1 | 24 | // #[dbus_proxy( 25 | || interface = "org.freedesktop.Notifications", 26 | || default_service = "org.freedesktop.Notifications", 27 | || default_path = "/org/freedesktop/Notifications" 28 | || )] | ||__- in this procedural macro expansion ... | 49 | | expire_timeout: i32, 50 | | ) -> zbus::Result<u32>; | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default = note: this warning originates in the attribute macro `dbus_proxy` (in Nightly builds, run with -Z macro-backtrace for more info)
this function has too many arguments (9/7): cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs#L24
warning: this function has too many arguments (9/7) --> cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs:24:1 | 24 | / #[dbus_proxy( 25 | | interface = "org.freedesktop.Notifications", 26 | | default_service = "org.freedesktop.Notifications", 27 | | default_path = "/org/freedesktop/Notifications" 28 | | )] | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: this warning originates in the attribute macro `dbus_proxy` (in Nightly builds, run with -Z macro-backtrace for more info)
useless conversion to the same type: `&str`: cosmic-applet-notifications/src/main.rs#L164
warning: useless conversion to the same type: `&str` --> cosmic-applet-notifications/src/main.rs:164:31 | 164 | .watch_config(cosmic_notifications_config::ID.into()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cosmic_notifications_config::ID` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default