fix: workspaces scrolling #73
wash2ci.yml
on: pull_request
formatting
13s
linting
2m 15s
Annotations
10 warnings
|
field `icon` is never read:
cosmic-panel-button/src/main.rs#L9
warning: field `icon` is never read
--> cosmic-panel-button/src/main.rs:9:5
|
7 | struct Desktop {
| ------- field in this struct
8 | name: String,
9 | icon: Option<String>,
| ^^^^
|
= note: `Desktop` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
|
variant `Errored` is never constructed:
cosmic-applet-workspaces/src/components/app.rs#L41
warning: variant `Errored` is never constructed
--> cosmic-applet-workspaces/src/components/app.rs:41:5
|
37 | enum Message {
| ------- variant in this enum
...
41 | Errored,
| ^^^^^^^
|
= note: `Message` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
|
variants `SetPairable` and `SetDiscoverable` are never constructed:
cosmic-applet-bluetooth/src/bluetooth.rs#L121
warning: variants `SetPairable` and `SetDiscoverable` are never constructed
--> cosmic-applet-bluetooth/src/bluetooth.rs:121:5
|
119 | pub enum BluerRequest {
| ------------ variants in this enum
120 | SetBluetoothEnabled(bool),
121 | SetPairable(bool),
| ^^^^^^^^^^^
122 | SetDiscoverable(bool),
| ^^^^^^^^^^^^^^^
|
= note: `BluerRequest` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
|
non-canonical implementation of `partial_cmp` on an `Ord` type:
cosmic-applet-bluetooth/src/bluetooth.rs#L188
warning: non-canonical implementation of `partial_cmp` on an `Ord` type
--> cosmic-applet-bluetooth/src/bluetooth.rs:188:1
|
188 | / impl PartialOrd for BluerDevice {
189 | | fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
| | _______________________________________________________________________-
190 | || match self.status.cmp(&other.status) {
191 | || std::cmp::Ordering::Equal => {
192 | || Some(self.name.to_lowercase().cmp(&other.name.to_lowercase()))
... ||
195 | || }
196 | || }
| ||_____- help: change this to: `{ Some(self.cmp(other)) }`
197 | | }
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
= note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default
|
|
this function has too many arguments (9/7):
cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs#L24
warning: this function has too many arguments (9/7)
--> cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs:24:1
|
24 | // #[dbus_proxy(
25 | || interface = "org.freedesktop.Notifications",
26 | || default_service = "org.freedesktop.Notifications",
27 | || default_path = "/org/freedesktop/Notifications"
28 | || )]
| ||__- in this procedural macro expansion
... |
49 | | expire_timeout: i32,
50 | | ) -> zbus::Result<u32>;
| |___________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
= note: this warning originates in the attribute macro `dbus_proxy` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
this function has too many arguments (9/7):
cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs#L24
warning: this function has too many arguments (9/7)
--> cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs:24:1
|
24 | / #[dbus_proxy(
25 | | interface = "org.freedesktop.Notifications",
26 | | default_service = "org.freedesktop.Notifications",
27 | | default_path = "/org/freedesktop/Notifications"
28 | | )]
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: this warning originates in the attribute macro `dbus_proxy` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
cosmic-applet-audio/src/mpris_subscription.rs#L168
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> cosmic-applet-audio/src/mpris_subscription.rs:168:81
|
168 | let media_players = mpris2_zbus::media_player::MediaPlayer::new_all(&conn)
| ^^^^^ help: change this to: `conn`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
cosmic-applet-audio/src/mpris_subscription.rs#L227
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> cosmic-applet-audio/src/mpris_subscription.rs:227:87
|
227 | let players = mpris2_zbus::media_player::MediaPlayer::new_all(&conn)
| ^^^^^ help: change this to: `conn`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
cosmic-applet-audio/src/mpris_subscription.rs#L253
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> cosmic-applet-audio/src/mpris_subscription.rs:253:15
|
253 | a.cmp(&b)
| ^^ help: change this to: `b`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
non-binding `let` on a future:
cosmic-applet-audio/src/main.rs#L449
warning: non-binding `let` on a future
--> cosmic-applet-audio/src/main.rs:449:25
|
449 | / _ = tokio::spawn(async move {
450 | | tokio::time::sleep(tokio::time::Duration::from_secs(30)).await;
451 | | conn.send(pulse::Message::UpdateConnection);
452 | | });
| |__________________________^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
= note: `#[warn(clippy::let_underscore_future)]` on by default
|