feat: cosmic-panel-button in multicall #993
wiiznokesci.yml
on: pull_request
formatting
14s
linting
2m 29s
Annotations
10 warnings
|
taken reference of right operand:
cosmic-app-list/cosmic-app-list-config/src/lib.rs#L45
warning: taken reference of right operand
--> cosmic-app-list/cosmic-app-list-config/src/lib.rs:45:63
|
45 | if let Some(pos) = self.favorites.iter().position(|e| e == &id) {
| ^^^^^---
| |
| help: use the right value directly: `id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: `#[warn(clippy::op_ref)]` on by default
|
|
unused import: `fs`:
cosmic-app-list/src/app.rs#L65
warning: unused import: `fs`
--> cosmic-app-list/src/app.rs:65:33
|
65 | use std::{collections::HashMap, fs, path::PathBuf, rc::Rc, str::FromStr, time::Duration};
| ^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
this `if` statement can be collapsed:
cosmic-applet-audio/src/mouse_area.rs#L301
warning: this `if` statement can be collapsed
--> cosmic-applet-audio/src/mouse_area.rs:301:9
|
301 | / if !state.is_out_of_bounds {
302 | | if widget
303 | | .on_mouse_enter
304 | | .as_ref()
... |
315 | | }
316 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
301 ~ if !state.is_out_of_bounds && widget
302 + .on_mouse_enter
303 + .as_ref()
304 + .or(widget.on_mouse_exit.as_ref())
305 + .is_some() {
306 + if let Event::Mouse(mouse::Event::CursorMoved { .. }) = event {
307 + state.is_out_of_bounds = true;
308 + if let Some(message) = widget.on_mouse_exit.as_ref() {
309 + shell.publish(message.clone());
310 + }
311 + return event::Status::Captured;
312 + }
313 + }
|
|
|
unused imports: `Rectangle` and `protocols::xdg::shell::client::xdg_positioner::Anchor`:
cosmic-applet-audio/src/lib.rs#L16
warning: unused imports: `Rectangle` and `protocols::xdg::shell::client::xdg_positioner::Anchor`
--> cosmic-applet-audio/src/lib.rs:16:38
|
16 | cctk::sctk::reexports::{calloop, protocols::xdg::shell::client::xdg_positioner::Anchor},
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
21 | window, Alignment, Length, Limits, Rectangle, Subscription,
| ^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
field `0` is never read:
cosmic-applet-audio/src/pulse.rs#L447
warning: field `0` is never read
--> cosmic-applet-audio/src/pulse.rs:447:16
|
447 | IterateErr(IterateResult),
| ---------- ^^^^^^^^^^^^^
| |
| field in this variant
|
= note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
447 | IterateErr(()),
| ~~
|
|
field `0` is never read:
cosmic-applet-audio/src/pulse.rs#L448
warning: field `0` is never read
--> cosmic-applet-audio/src/pulse.rs:448:16
|
448 | ContextErr(pulse::context::State),
| ---------- ^^^^^^^^^^^^^^^^^^^^^
| |
| field in this variant
|
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
448 | ContextErr(()),
| ~~
|
|
field `0` is never read:
cosmic-applet-audio/src/pulse.rs#L449
warning: field `0` is never read
--> cosmic-applet-audio/src/pulse.rs:449:18
|
449 | OperationErr(pulse::operation::State),
| ------------ ^^^^^^^^^^^^^^^^^^^^^^^
| |
| field in this variant
|
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
449 | OperationErr(()),
| ~~
|
|
field `0` is never read:
cosmic-applet-audio/src/pulse.rs#L450
warning: field `0` is never read
--> cosmic-applet-audio/src/pulse.rs:450:11
|
450 | PAErr(PAErr),
| ----- ^^^^^
| |
| field in this variant
|
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
450 | PAErr(()),
| ~~
|
|
field `0` is never read:
cosmic-applet-audio/src/pulse.rs#L452
warning: field `0` is never read
--> cosmic-applet-audio/src/pulse.rs:452:10
|
452 | Misc(&'a str),
| ---- ^^^^^^^
| |
| field in this variant
|
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
452 | Misc(()),
| ~~
|
|
fields `user_name`, `host_name`, `server_version`, `server_name`, and `cookie` are never read:
cosmic-applet-audio/src/pulse.rs#L805
warning: fields `user_name`, `host_name`, `server_version`, `server_name`, and `cookie` are never read
--> cosmic-applet-audio/src/pulse.rs:805:9
|
803 | pub struct ServerInfo {
| ---------- fields in this struct
804 | /// User name of the daemon process.
805 | pub user_name: Option<String>,
| ^^^^^^^^^
806 | /// Host name the daemon is running on.
807 | pub host_name: Option<String>,
| ^^^^^^^^^
808 | /// Version string of the daemon.
809 | pub server_version: Option<String>,
| ^^^^^^^^^^^^^^
810 | /// Server package name (usually “pulseaudio”).
811 | pub server_name: Option<String>,
| ^^^^^^^^^^^
...
819 | pub cookie: u32,
| ^^^^^^
|
= note: `ServerInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
|