Skip to content

feat: cosmic-panel-button in multicall #989

feat: cosmic-panel-button in multicall

feat: cosmic-panel-button in multicall #989

Triggered via pull request September 8, 2024 14:19
Status Success
Total duration 2m 32s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
taken reference of right operand: cosmic-app-list/cosmic-app-list-config/src/lib.rs#L45
warning: taken reference of right operand --> cosmic-app-list/cosmic-app-list-config/src/lib.rs:45:63 | 45 | if let Some(pos) = self.favorites.iter().position(|e| e == &id) { | ^^^^^--- | | | help: use the right value directly: `id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `#[warn(clippy::op_ref)]` on by default
this `if` statement can be collapsed: cosmic-applet-audio/src/mouse_area.rs#L301
warning: this `if` statement can be collapsed --> cosmic-applet-audio/src/mouse_area.rs:301:9 | 301 | / if !state.is_out_of_bounds { 302 | | if widget 303 | | .on_mouse_enter 304 | | .as_ref() ... | 315 | | } 316 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if = note: `#[warn(clippy::collapsible_if)]` on by default help: collapse nested if block | 301 ~ if !state.is_out_of_bounds && widget 302 + .on_mouse_enter 303 + .as_ref() 304 + .or(widget.on_mouse_exit.as_ref()) 305 + .is_some() { 306 + if let Event::Mouse(mouse::Event::CursorMoved { .. }) = event { 307 + state.is_out_of_bounds = true; 308 + if let Some(message) = widget.on_mouse_exit.as_ref() { 309 + shell.publish(message.clone()); 310 + } 311 + return event::Status::Captured; 312 + } 313 + } |
unused imports: `Rectangle` and `protocols::xdg::shell::client::xdg_positioner::Anchor`: cosmic-applet-audio/src/lib.rs#L16
warning: unused imports: `Rectangle` and `protocols::xdg::shell::client::xdg_positioner::Anchor` --> cosmic-applet-audio/src/lib.rs:16:38 | 16 | cctk::sctk::reexports::{calloop, protocols::xdg::shell::client::xdg_positioner::Anchor}, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... 21 | window, Alignment, Length, Limits, Rectangle, Subscription, | ^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
field `0` is never read: cosmic-applet-audio/src/pulse.rs#L422
warning: field `0` is never read --> cosmic-applet-audio/src/pulse.rs:422:16 | 422 | IterateErr(IterateResult), | ---------- ^^^^^^^^^^^^^ | | | field in this variant | = note: `#[warn(dead_code)]` on by default help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 422 | IterateErr(()), | ~~
field `0` is never read: cosmic-applet-audio/src/pulse.rs#L423
warning: field `0` is never read --> cosmic-applet-audio/src/pulse.rs:423:16 | 423 | ContextErr(pulse::context::State), | ---------- ^^^^^^^^^^^^^^^^^^^^^ | | | field in this variant | help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 423 | ContextErr(()), | ~~
field `0` is never read: cosmic-applet-audio/src/pulse.rs#L424
warning: field `0` is never read --> cosmic-applet-audio/src/pulse.rs:424:18 | 424 | OperationErr(pulse::operation::State), | ------------ ^^^^^^^^^^^^^^^^^^^^^^^ | | | field in this variant | help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 424 | OperationErr(()), | ~~
field `0` is never read: cosmic-applet-audio/src/pulse.rs#L425
warning: field `0` is never read --> cosmic-applet-audio/src/pulse.rs:425:11 | 425 | PAErr(PAErr), | ----- ^^^^^ | | | field in this variant | help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 425 | PAErr(()), | ~~
field `0` is never read: cosmic-applet-audio/src/pulse.rs#L427
warning: field `0` is never read --> cosmic-applet-audio/src/pulse.rs:427:10 | 427 | Misc(&'a str), | ---- ^^^^^^^ | | | field in this variant | help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 427 | Misc(()), | ~~
fields `user_name`, `host_name`, `server_version`, `server_name`, and `cookie` are never read: cosmic-applet-audio/src/pulse.rs#L780
warning: fields `user_name`, `host_name`, `server_version`, `server_name`, and `cookie` are never read --> cosmic-applet-audio/src/pulse.rs:780:9 | 778 | pub struct ServerInfo { | ---------- fields in this struct 779 | /// User name of the daemon process. 780 | pub user_name: Option<String>, | ^^^^^^^^^ 781 | /// Host name the daemon is running on. 782 | pub host_name: Option<String>, | ^^^^^^^^^ 783 | /// Version string of the daemon. 784 | pub server_version: Option<String>, | ^^^^^^^^^^^^^^ 785 | /// Server package name (usually “pulseaudio”). 786 | pub server_name: Option<String>, | ^^^^^^^^^^^ ... 794 | pub cookie: u32, | ^^^^^^ | = note: `ServerInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
using `.iter().next()` on an array: cosmic-applet-audio/src/mouse_area.rs#L268
warning: using `.iter().next()` on an array --> cosmic-applet-audio/src/mouse_area.rs:268:30 | 268 | if let Some(state) = state.children.iter().next() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling: `state.children.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice = note: `#[warn(clippy::iter_next_slice)]` on by default