Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom fallback #60

Merged
merged 9 commits into from
Dec 12, 2023
Merged

Custom fallback #60

merged 9 commits into from
Dec 12, 2023

Conversation

teseoch
Copy link
Member

@teseoch teseoch commented Dec 8, 2023

No description provided.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (b08ab23) 89.01% compared to head (efd79f7) 89.01%.

Files Patch % Lines
src/polysolve/nonlinear/Solver.cpp 81.08% 14 Missing ⚠️
...c/polysolve/nonlinear/descent_strategies/LBFGS.cpp 50.00% 1 Missing ⚠️
...near/descent_strategies/box_constraints/LBFGSB.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   89.01%   89.01%   -0.01%     
==========================================
  Files          51       51              
  Lines        1948     1993      +45     
==========================================
+ Hits         1734     1774      +40     
- Misses        214      219       +5     
Flag Coverage Δ
polysolve 89.01% <85.96%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nonlinear-solver-spec.json Show resolved Hide resolved
nonlinear-solver-spec.json Show resolved Hide resolved
@@ -24,6 +24,75 @@

namespace polysolve::nonlinear
{
namespace
{
std::shared_ptr<DescentStrategy> crate_solver(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@teseoch teseoch merged commit 374f787 into main Dec 12, 2023
7 of 9 checks passed
@teseoch teseoch deleted the custom-fallback branch December 12, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants