Rule 19-35 raised messaged fix #1561
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eset-checking-tool into RT/JG/undetermined_text
…lighting_space_types_defined is set to true but never evaluated. This logic fails to identify that one of the spaces in the baseline RMI is missing a lighting_space_type. Likewise, a fix was needed for checking the are_any_lighting_space_types_defined parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error found in the create_data function for 19-35. The parameter all_lighting_space_types_defined is set to true but never evaluated. This logic fails to identify that one of the spaces in the baseline RMI is missing a lighting_space_type. Likewise, a fix was needed for checking the are_any_lighting_space_types_defined parameter.