Create Rule5-43.md #1539
Create Rule5-43.md #1539
Conversation
KarenWGard
requested review from
JasonGlazer,
supriyagoel,
weilixu,
claperle and
JacksonJ-KC
docs/section5/Rule5-43.md
Outdated
| **Rule ID:** 5-43 | ||
| **Rule Description:** Automatic fenestration shading devices shall not be modeled in the Baseline. | ||
| **Rule Assertion:** Baseline RMD = expected value | ||
| **Appendix G Section:** Section G3.1-5(d) Building Envelope Modeling Requirements for the Baseline building |
There was a problem hiding this comment.
I feel like I am going crazy, I don't see where it addresses automatic shading devices for the baseline in the Baseline Building Performance column in d.
There was a problem hiding this comment.
this is ASHRAE 2022
There was a problem hiding this comment.
Still in 90.1 2022 not seeing anything about shading in Section G3.1-5(d) Building Envelope Modeling Requirements for the Baseline building
There was a problem hiding this comment.
it's actually 5f, but it's there. I updated the reference:
docs/section5/Rule5-43.md
Outdated
| **Rule Description:** Automatic fenestration shading devices shall not be modeled in the Baseline. | ||
| **Rule Assertion:** Baseline RMD = expected value | ||
| **Appendix G Section:** Section G3.1-5(d) Building Envelope Modeling Requirements for the Baseline building | ||
| **Appendix G Section Reference:** Tables G3.4-1 to G3.4-8 |
There was a problem hiding this comment.
I don't think these are relevant for this RDS
docs/section5/Rule5-43.md
Outdated
|
|
||
| **Rule Assertion:** | ||
| - Case 1: If the baseline subsurface does not have shading devices, then pass: `if not automatic_shades_modeled: PASS` | ||
| - Case 2: If the baseline subsurface has shading devices, then fail: `if not automatic_shades_modeled: FAIL` |
There was a problem hiding this comment.
I think the not needs to be removed from this
docs/section5/Rule5-43.md
Outdated
| NONE | ||
|
|
||
| ## Applicability Check: | ||
| - look at each zone: `for zone in B_RMD...zones:` |
There was a problem hiding this comment.
I don't see the point of the nested loops. Why not start with for subsurface in B_RMD...subsurfaces"?
There was a problem hiding this comment.
from your comments, I think that you're suggesting that the rule should be evaluated at the building level, not the subsurface level. This makes sense. I updated the rule. & added an applicability check that the subsurfaces be exterior surfaces
|
|
||
| NONE | ||
|
|
||
| ## Applicability Check: |
There was a problem hiding this comment.
There does not appear to be any applicability checks in the "Applicability Check" section. I don't understand why this loop is in this section
There was a problem hiding this comment.
from your comments, I think that you're suggesting that the rule should be evaluated at the building level, not the subsurface level. This makes sense. I updated the rule. & added an applicability check that the subsurfaces be exterior surfaces
There was a problem hiding this comment.
this whole section I think can be simplified to if len(B_RMD...subsurfaces) == 0: NOT APPLICABLE
|
|
||
| ## Rule Logic: | ||
| - create a list automatic_shades_modeled and initialize it as an empty list: `automatic_shades_modeled = []` | ||
| - look at each zone: `for zone in B_RMD...zones:` |
There was a problem hiding this comment.
nothing is being referenced from the zone or surface - we can go directly to subsurface
No description provided.