romio: implement binding generation for ROMIO #7228
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add io_api.txt and generate io bindings
We provide them in errhan_api.txt.
IO apis need additional adaptations. Also enhance the script by adding scan_custom_error_check so that if we use custom error checking, esp. with CHECKENUM or CHECKMASK, we automatically skip the default validation check.
Generate io bindings including prototypes in mpi_proto.h and mpir_impl.h. src/binding/c/io.c caintains all the IO binding functions that calls the corresponding _impl functions. But it is not included in the Makefile yet.
Define the complete MPI-IO interface in mpi.h. In all_romio_symbols.c, we can use MPI_Request instead of MPIO_Reuqest since MPIO_Request is not longer defined in mpi.h (since it no longer includes mpio.h).
These looks like vendor-specific code. We can easily generate them if needed. Remove them for now to simplify refactor.
All romio error check macros takes a myname parameter (which can be replaced by __func__). Make MPIO_CHECK_INFO_ALL consistent.
Refactor to split interface and implementation. This prepares for binding generations. This commit refactors MPI_File_open and MPI_File_close.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Integrate ROMIO into MPICH's binding generation framework. This will unify and simplify the IO binding tasks such as large count support, fortran support, man page support.
We'll retain the current stand-alone nature of ROMIO as much as we can in this PR. There shouldn't be any noticeable difference for users who build ROMIO separate from MPICH.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.